New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mojo Blob URLs] Handle more navigation cases. #10295

Merged
merged 1 commit into from May 28, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Collaborator

chromium-wpt-export-bot commented Apr 3, 2018

This changes two more IPCs to resolve blob URLs in blink before
sending the request to the browser, hopefully covering all cases.

Still only works with the network service enabled (and that's
probably not going to change), but at least fixes ordering issues
the network service had between resolving and revoking blob URLs.

Design doc: https://docs.google.com/document/d/1DqVcTWE9Qb_3KpIRH2bFV-6hWEr8S92c4ppY67YL1KI/edit#heading=h.n4fzuc6mgziv

Bug: 800901
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iad88fc87264b248d15b03bdad2c24d2c5a46d9df
Reviewed-on: https://chromium-review.googlesource.com/899508
Reviewed-by: Camille Lamy clamy@chromium.org
Reviewed-by: Kinuko Yasuda kinuko@chromium.org
Reviewed-by: Scott Violet sky@chromium.org
Reviewed-by: Nasko Oskov nasko@chromium.org
Commit-Queue: Marijn Kruisselbrink mek@chromium.org
Cr-Commit-Position: refs/heads/master@{#561670}

@wpt-pr-bot

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 3, 2018

Build PASSED

Started: 2018-04-04 21:27:34
Finished: 2018-04-04 21:28:33

View more information about this build on:

[Mojo Blob URLs] Handle more navigation cases.
This changes two more IPCs to resolve blob URLs in blink before
sending the request to the browser, hopefully covering all cases.

Still only works with the network service enabled (and that's
probably not going to change), but at least fixes ordering issues
the network service had between resolving and revoking blob URLs.

Design doc: https://docs.google.com/document/d/1DqVcTWE9Qb_3KpIRH2bFV-6hWEr8S92c4ppY67YL1KI/edit#heading=h.n4fzuc6mgziv

Bug: 800901
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iad88fc87264b248d15b03bdad2c24d2c5a46d9df
Reviewed-on: https://chromium-review.googlesource.com/899508
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561670}

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 68b2bc7 into master May 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-899508 branch May 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment