New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide thumbnails in DownloadUIAdapter #10297

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@chromium-wpt-export-bot
Collaborator

chromium-wpt-export-bot commented Apr 3, 2018

This makes thumbnails show up in downloads home and notifications
for prefetched pages.

Bug: 794828
Change-Id: I77a1dd34d71c6b56531e31325ee7a13edc992229
Reviewed-on: https://chromium-review.googlesource.com/990201
WPT-Export-Revision: 2cf031581d6c080b8d248d771c987f055f9095b6

Provide thumbnails in DownloadUIAdapter
This makes thumbnails show up in downloads home and notifications
for prefetched pages.

Bug: 794828
Change-Id: I77a1dd34d71c6b56531e31325ee7a13edc992229
@wpt-pr-bot

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 3, 2018

Build PASSED

Started: 2018-04-03 23:05:06
Finished: 2018-04-03 23:20:38

View more information about this build on:

@@ -282,15 +282,4 @@
}, `Setting transceiver.currentDirection to recvonly in the middle of tonechange events should stop future tonechange events from firing`);
/* Section 7.3 - Tone change event */

This comment has been minimized.

@alvestrand

alvestrand Apr 24, 2018

Contributor

This seems like an unrelated change. Please justify.

@alvestrand

This comment has been minimized.

Contributor

alvestrand commented Apr 24, 2018

Inspecting the original CL, it seems to have reverted out all the files that touched the WPT.
Closing CL.

@alvestrand alvestrand closed this Apr 24, 2018

@alvestrand

This comment has been minimized.

Contributor

alvestrand commented Apr 24, 2018

@foolip do we have a bug open for getting CLs closed out when the Chromium CL decides it doesn't want to change the WPT anyway, or is that a manual procedure?

@foolip foolip deleted the chromium-export-cl-990201 branch Apr 24, 2018

@foolip

This comment has been minimized.

Contributor

foolip commented Apr 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment