Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie Store: rework tests for 'expires' option #10298

Merged
merged 1 commit into from Apr 6, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Apr 3, 2018

Simplify/rework the tests for the 'expires' options. Don't run the
tests with the special secure-only prefixes, as that's orthogonal to
the behvior.

In Chromium, this also reveals that support for HTTP date strings as
'expires' values, as described in the explainer[1] is not yet
supported.

[1] https://github.com/WICG/cookie-store/blob/gh-pages/explainer.md

Bug: 729800
Change-Id: I015fd643f18b59c8294f9dc62d576682132795fd
Reviewed-on: https://chromium-review.googlesource.com/994284
Commit-Queue: Joshua Bell jsbell@chromium.org
Reviewed-by: Victor Costan pwnall@chromium.org
Cr-Commit-Position: refs/heads/master@{#548818}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Apr 3, 2018

Build PASSED

Started: 2018-04-03 23:39:48
Finished: 2018-04-03 23:51:17

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-994284 branch from 0877266 to 350a3fe Apr 5, 2018

Cookie Store: rework tests for 'expires' option
Simplify/rework the tests for the 'expires' options. Don't run the
tests with the special secure-only prefixes, as that's orthogonal to
the behvior.

In Chromium, this also reveals that support for HTTP date strings as
'expires' values, as described in the explainer[1] is not yet
supported.

[1] https://github.com/WICG/cookie-store/blob/gh-pages/explainer.md

Bug: 729800
Change-Id: I015fd643f18b59c8294f9dc62d576682132795fd
Reviewed-on: https://chromium-review.googlesource.com/994284
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548818}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-994284 branch from 350a3fe to 2f98030 Apr 6, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 8b9501b into master Apr 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-994284 branch Apr 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.