New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Add support for border properties. #10299

Merged
merged 1 commit into from Apr 6, 2018

Conversation

Projects
None yet
5 participants
@chromium-wpt-export-bot
Collaborator

chromium-wpt-export-bot commented Apr 4, 2018

border-radius-* tests are failing because the computed value should
always be a pair of values, but Blink currently returns a CSSValuePair
with kDropIdenticalValue, so we sometimes compute to a single value.

Fixing this requires either changing computed border-radius-* to use
kKeepIdenticalValue, or overriding the computed value just for Typed OM
[1]

[1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp?q=ComputedStylePropertyMap.cpp&dr&l=229

Bug: 820299
Change-Id: I4c67a7986a8e77d37e7936eabfa0b68b32de9df8
Reviewed-on: https://chromium-review.googlesource.com/994433
Commit-Queue: Darren Shen shend@chromium.org
Reviewed-by: Rune Lillesveen futhark@chromium.org
Cr-Commit-Position: refs/heads/master@{#548697}

@wpt-pr-bot

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 4, 2018

Build ERRORED

Started: 2018-04-04 01:31:56
Finished: 2018-04-04 02:24:25

Failing Jobs

  • firefox:nightly

View more information about this build on:

[css-typed-om] Add support for border properties.
border-radius-* tests are failing because the computed value should
always be a pair of values, but Blink currently returns a CSSValuePair
with kDropIdenticalValue, so we sometimes compute to a single value.

Fixing this requires either changing computed border-radius-* to use
kKeepIdenticalValue, or overriding the computed value just for Typed OM
[1]

[1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp?q=ComputedStylePropertyMap.cpp&dr&l=229

Bug: 820299
Change-Id: I4c67a7986a8e77d37e7936eabfa0b68b32de9df8
Reviewed-on: https://chromium-review.googlesource.com/994433
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548697}
@foolip

This comment has been minimized.

Contributor

foolip commented Apr 6, 2018

#7660 strikes again.

@foolip foolip merged commit 487c4a8 into master Apr 6, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@foolip foolip deleted the chromium-export-cl-994433 branch Apr 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment