New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Server-Timing tests for Webkit #10302

Merged
merged 3 commits into from Apr 5, 2018

Conversation

Projects
None yet
4 participants
@cvazac
Contributor

cvazac commented Apr 4, 2018

server-timing/cross_origin.html:
LayoutTests for Webkit run on localhost (not on web-platform.test), a suitable cross-domain url is 127.0.0.1

server-timing/server_timing_header-parsing.html:
LayoutTests for Webkit require asserts to be executed in the same order every time. The changes here queue up the tests to run, and run them in order when they are all done.

All other changes are minor refactoring and DRY.

@wpt-pr-bot

This comment has been minimized.

Collaborator

wpt-pr-bot commented Apr 4, 2018

There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 4, 2018

Build PASSED

Started: 2018-04-04 14:21:02
Finished: 2018-04-04 14:28:14

View more information about this build on:

@yoavweiss yoavweiss self-requested a review Apr 4, 2018

@yoavweiss

LGTM

@yoavweiss yoavweiss merged commit 8e19a80 into web-platform-tests:master Apr 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment