New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify assert_throws in two places where error messages were passed #10303

Merged
merged 1 commit into from Apr 4, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Collaborator

chromium-wpt-export-bot commented Apr 4, 2018

This was discovered in
https://chromium-review.googlesource.com/c/chromium/src/+/980757 by
letting assert_throws also check that the message matches. That change
itself isn't a good idea, but it's still just as well to use plain
TypeErrors here to not make it seems like more is being tested than in
fact is.

Change-Id: I8f964e9b25cc94942cb86f3ee0017530f230e04a
Reviewed-on: https://chromium-review.googlesource.com/995192
Reviewed-by: Adam Rice ricea@chromium.org
Reviewed-by: Mounir Lamouri mlamouri@chromium.org
Commit-Queue: Philip Jägenstedt foolip@chromium.org
Cr-Commit-Position: refs/heads/master@{#548060}

@wpt-pr-bot

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 4, 2018

Build PASSED

Started: 2018-04-04 15:28:14
Finished: 2018-04-04 15:43:27

Failing Jobs

  • build_css

View more information about this build on:

Simplify assert_throws in two places where error messages were passed
This was discovered in
https://chromium-review.googlesource.com/c/chromium/src/+/980757 by
letting assert_throws also check that the message matches. That change
itself isn't a good idea, but it's still just as well to use plain
TypeErrors here to not make it seems like more is being tested than in
fact is.

Change-Id: I8f964e9b25cc94942cb86f3ee0017530f230e04a
Reviewed-on: https://chromium-review.googlesource.com/995192
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548060}

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 168e0e1 into master Apr 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-995192 branch Apr 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment