New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1435632] Fix the logic to do layout stuff after reassigning a slot. #10310

Merged
merged 1 commit into from Apr 4, 2018

Conversation

Projects
None yet
4 participants
@moz-wptsync-bot
Collaborator

moz-wptsync-bot commented Apr 4, 2018

The dirty bit fiddling is nontrivial, but it's pretty much what we do for
invalidation and allows to keep this incrementally easily.

The only caller that we cared about for the GetFlattenedTreeParent check in
DestroyFramesForAndRestyle was the old ShadowRoot invalidation functions that
went away.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1435632
gecko-commit: 284b9d43b1135581e88a14c2b135b63cc4720fd1
gecko-integration-branch: central
gecko-reviewers: smaug, xidorn

Fix the logic to do layout stuff after reassigning a slot.
The dirty bit fiddling is nontrivial, but it's pretty much what we do for
invalidation and allows to keep this incrementally easily.

The only caller that we cared about for the GetFlattenedTreeParent check in
DestroyFramesForAndRestyle was the old ShadowRoot invalidation functions that
went away.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1435632
gecko-commit: 284b9d43b1135581e88a14c2b135b63cc4720fd1
gecko-integration-branch: central
gecko-reviewers: smaug, xidorn
@wpt-pr-bot

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 4, 2018

Build PASSED

Started: 2018-04-04 18:43:44
Finished: 2018-04-04 18:45:26

View more information about this build on:

@moz-wptsync-bot moz-wptsync-bot merged commit 9741b4e into master Apr 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
upstream/gecko Landed on mozilla-central
Details

@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1435632 branch Apr 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment