New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1446246] part 2. Combine HTMLConstructor and CreateXULOrHTMLElement into a single function. #10311

Merged
merged 1 commit into from Apr 4, 2018

Conversation

Projects
None yet
6 participants
@moz-wptsync-bot
Collaborator

moz-wptsync-bot commented Apr 4, 2018

This fixes an observable bug we had due to doing the steps in a different order
from the spec: the 'prototype' get can have side-effects so needs to happen
after some of the other sanity checks.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1446246
gecko-commit: 9ed0718ede32ea01c67a47b8f143152e860a8be2
gecko-integration-branch: central
gecko-reviewers: peterv

part 2. Combine HTMLConstructor and CreateXULOrHTMLElement into a sin…
…gle function.

This fixes an observable bug we had due to doing the steps in a different order
from the spec: the 'prototype' get can have side-effects so needs to happen
after some of the other sanity checks.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1446246
gecko-commit: 9ed0718ede32ea01c67a47b8f143152e860a8be2
gecko-integration-branch: central
gecko-reviewers: peterv
@wpt-pr-bot

Already reviewed downstream.

@winly66

This comment has been minimized.

winly66 commented on 776f1c4 Apr 4, 2018

Commited

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 4, 2018

Build ERRORED

Started: 2018-04-04 19:17:32
Finished: 2018-04-04 19:49:28

Failing Jobs

  • firefox:nightly

View more information about this build on:

@bzbarsky

This comment has been minimized.

Contributor

bzbarsky commented Apr 4, 2018

@jgraham Is there a way to retrigger the failing test? It looks like it just timed out...

@jgraham

This comment has been minimized.

Contributor

jgraham commented Apr 4, 2018

I can force merge this. I wonder why this ran in 10 minutes in Chrome, but timed out after 50 minutes in Firefox.

@jgraham jgraham merged commit 9a3fdb4 into master Apr 4, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
upstream/gecko Landed on mozilla-central
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment