Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Actions in executorselenium #10312
This is an implementation of actions in executorselenium. Would like some feedback before I polish it up/make more changes if necessary.
Want to open a discussion with this and show one possibility for the API.
So this seems to pretty directly expose the selenium client API, which isn't defined anywhere and so is hard to accurately reproduce. This is why I want to ensure we work with non-Selenium implementations for this feature. With that in mind, I think we should make the testdriver API a builder with the same primitives as the underlying webdriver API i.e. pointer up down, move; key up and down; pause, and anything else I forgot. This is obviously more implementation work, but I'm pretty sure that putting the higher-level API in the js rather than in the backend is the way to go.
From a marionette point of view it exposes the commands needed for the W3C API, but you have to opt in to avoid the legacy implementation. This will require some changes that I'm happy to make.
referenced this pull request
Apr 18, 2018
Just wanted to get an update on this. @kereliuk are you working on this? Are you clear with what James refers to?
Apologies I forgot to reply to this.
Yep, I think he has a point and we plan to move Chrome to a more generic executor to allow this.
Sorry for the delay on this again! Let me know if you have any other questions.