New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added testdriver automation for html/editing/focus/focus-02.html #10315

Merged
merged 1 commit into from Apr 5, 2018

Conversation

Projects
None yet
5 participants
@kereliuk
Contributor

kereliuk commented Apr 4, 2018

Automate all the things!

@wpt-pr-bot wpt-pr-bot added the html label Apr 4, 2018

@wpt-pr-bot wpt-pr-bot requested review from ayg, jdm, jgraham and zqzhang Apr 4, 2018

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 4, 2018

Build PASSED

Started: 2018-04-04 20:29:08
Finished: 2018-04-04 20:38:46

View more information about this build on:

@@ -7,12 +7,8 @@
<meta assert="assert" content="Check if the key events received by document are targeted at the element when no element is focused">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<h2>Steps:</h2>

This comment has been minimized.

@jgraham

jgraham Apr 4, 2018

Contributor

Do we have some convention about leaving manual steps in here so that they can be run without testdriver?

This comment has been minimized.

@foolip

foolip Apr 5, 2018

Contributor

Not really. I think leaving the alone where they exist would be OK, but I wouldn't expect the instructions to stay working over time, or that they'd be added for new tests, so I'd perhaps slightly prefer removing them. WDYT?

This comment has been minimized.

@kereliuk

kereliuk Apr 5, 2018

Contributor

I think they should be removed.
When new tests are added with testdriver they generally aren't accompanied by manual steps incase they are run without testdriver, so I think we should stick to this convention. I also agree with what @foolip says with maintenance, but @jgraham you bring up a good point that makes me wonder whether we should even allow testdriver tests to be run in any other way than wpt run. I opened #10330 to further address this.

@foolip

foolip approved these changes Apr 5, 2018

@@ -7,12 +7,8 @@
<meta assert="assert" content="Check if the key events received by document are targeted at the element when no element is focused">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<h2>Steps:</h2>

This comment has been minimized.

@foolip

foolip Apr 5, 2018

Contributor

Not really. I think leaving the alone where they exist would be OK, but I wouldn't expect the instructions to stay working over time, or that they'd be added for new tests, so I'd perhaps slightly prefer removing them. WDYT?

@kereliuk kereliuk merged commit 841f3f5 into web-platform-tests:master Apr 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment