New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1449010] Respect ::selection background styles for image overlays. #10316

Merged
merged 1 commit into from Apr 9, 2018

Conversation

Projects
None yet
4 participants
@moz-wptsync-bot
Collaborator

moz-wptsync-bot commented Apr 4, 2018

I don't have a strong preference about blending with white vs. just doing alpha
0.5, so I kept doing what we were doing, since Blink and WebKit also apply the
blending to the text background, and I'm not sure that's particularly desirable.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1449010
gecko-commit: 6d2897cca552917317e11a34e2bb410431ef5619
gecko-integration-branch: central
gecko-reviewers: mattwoodrow


This change is Reviewable

Respect ::selection background styles for image overlays.
I don't have a strong preference about blending with white vs. just doing alpha
0.5, so I kept doing what we were doing, since Blink and WebKit also apply the
blending to the text background, and I'm not sure that's particularly desirable.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1449010
gecko-commit: 6d2897cca552917317e11a34e2bb410431ef5619
gecko-integration-branch: central
gecko-reviewers: mattwoodrow
@wpt-pr-bot

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 4, 2018

Build PASSED

Started: 2018-04-04 21:46:41
Finished: 2018-04-04 21:47:49

View more information about this build on:

@moz-wptsync-bot moz-wptsync-bot merged commit 99e1ae2 into master Apr 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
upstream/gecko Landed on mozilla-central
Details

@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1449010 branch Apr 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment