New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stylesheet of link element when rel != stylesheet #10325

Merged
merged 1 commit into from Apr 5, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Collaborator

chromium-wpt-export-bot commented Apr 5, 2018

Stylesheets from link elements that previously have rel = "stylesheet"
but then changed to something else should be removed/not considered
anymore until the rel attribute is changed back to "stylesheet" again.

Currently this works correctly for link elements in the document tree,
but fails in link elements within a shadow tree because link elements
in shadow tree with rel attribute != "stylesheet" are skipped from
processing. Because of that, the stylesheet in the link element was
never cleared and no style recalc happened.
JSBin from bug: http://jsbin.com/bojunajaju/edit?html,console,output

Bug: 817355
Change-Id: I57c71c79c0cc471d36eb988b8a81eef82c33548a
Reviewed-on: https://chromium-review.googlesource.com/995116
Commit-Queue: Rakina Zata Amni rakina@chromium.org
Reviewed-by: Hayato Ito hayato@chromium.org
Cr-Commit-Position: refs/heads/master@{#548357}

@wpt-pr-bot

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 5, 2018

Build PASSED

Started: 2018-04-05 07:26:57
Finished: 2018-04-05 07:33:54

View more information about this build on:

Remove stylesheet of link element when rel != stylesheet
Stylesheets from link elements that previously have rel = "stylesheet"
but then changed to something else should be removed/not considered
anymore until the rel attribute is changed back to "stylesheet" again.

Currently this works correctly for link elements in the document tree,
but fails in link elements within a shadow tree because link elements
in shadow tree with rel attribute != "stylesheet"  are skipped from
processing. Because of that, the stylesheet in the link element was
never cleared and no style recalc happened.
JSBin from bug: http://jsbin.com/bojunajaju/edit?html,console,output

Bug: 817355
Change-Id: I57c71c79c0cc471d36eb988b8a81eef82c33548a
Reviewed-on: https://chromium-review.googlesource.com/995116
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548357}

@wpt-pr-bot wpt-pr-bot added the html label Apr 5, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 5c9b2cf into master Apr 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-995116 branch Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment