New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra window.event tests #10329

Merged
merged 9 commits into from Jun 7, 2018

Conversation

Projects
None yet
4 participants
@annevk
Member

annevk commented Apr 5, 2018

To compliment #4790.

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 5, 2018

Build PENDING

Started: None
Finished: None

View more information about this build on:

annevk added a commit that referenced this pull request Apr 9, 2018

@annevk annevk referenced this pull request Apr 9, 2018

Merged

Test self.event in workers #10382

foolip added a commit that referenced this pull request Apr 9, 2018

Test self.event in workers
To compliment #10329. Needed for whatwg/dom#407.

annevk added a commit to miketaylr/dom that referenced this pull request Jun 4, 2018

Add window.event for web compatibility
Tests: web-platform-tests/wpt#4790 & web-platform-tests/wpt#10329.

Fixes whatwg#334.

Co-authored-by: Anne van Kesteren <annevk@annevk.nl>

annevk added a commit to miketaylr/dom that referenced this pull request Jun 4, 2018

Add window.event for web compatibility
Tests: web-platform-tests/wpt#4790 & web-platform-tests/wpt#10329.

Fixes whatwg#334.

Co-authored-by: Anne van Kesteren <annevk@annevk.nl>

@annevk annevk requested review from foolip and removed request for ayg Jun 7, 2018

foolip added some commits Jun 7, 2018

@foolip

foolip approved these changes Jun 7, 2018

Fixed some things, question about a comment, but great tests!

frame.src = "resources/event-global-extra-frame.html";
frame.onload = t.step_func_done(() => {
const event = new Event("hi");
document.addEventListener("hi", frame.contentWindow.listener); // listener intentionally not wrapped in t.step_func

This comment has been minimized.

@foolip

foolip Jun 7, 2018

Contributor

Can you comment here that it's because that would change the global of the event listener, if that's the case?

This comment has been minimized.

@annevk

annevk Jun 7, 2018

Member

It is.

@annevk annevk merged commit 6380b5c into master Jun 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@annevk annevk deleted the annevk/window-event-extra branch Jun 7, 2018

annevk added a commit to whatwg/dom that referenced this pull request Jun 7, 2018

Standardize window.event
Too many people like their global variables.

Tests: web-platform-tests/wpt#4790 & web-platform-tests/wpt#10329.

Fixes #334.

Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment