New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service worker: Add tests for inteception of workers after redirects. #10340

Merged
merged 1 commit into from Apr 9, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Collaborator

chromium-wpt-export-bot commented Apr 6, 2018

This tests behavior discussed here:
w3c/ServiceWorker#1289

Namely it tests when a request for a worker goes through a redirect
chain:

  1. On redirect from A -> B, whether the service worker at B
    sees the request.
  2. After the final redirect, which service worker controls the
    resulting client.

The tests are written as specified today. Therefore, Firefox
passes this test (verified in Nightly) and Chrome does not.
(Actually a small change is required to the test to make Firefox
pass it, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1452528)

Currently it only tests shared worker but dedicated worker can
be added in a follow-up patch.

Bug: 829720
Change-Id: Id3b1ea8b952760be0ef9917f2c6a3afe60ca1fb5
Reviewed-on: https://chromium-review.googlesource.com/999241
Commit-Queue: Matt Falkenhagen falken@chromium.org
Reviewed-by: Hiroki Nakagawa nhiroki@chromium.org
Cr-Commit-Position: refs/heads/master@{#549125}

@wpt-pr-bot

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 6, 2018

Build PENDING

Started: None
Finished: None

View more information about this build on:

service worker: Add tests for inteception of workers after redirects.
This tests behavior discussed here:
w3c/ServiceWorker#1289

Namely it tests when a request for a worker goes through a redirect
chain:
1) On redirect from A -> B, whether the service worker at B
sees the request.
2) After the final redirect, which service worker controls the
resulting client.

The tests are written as specified today. Therefore, Firefox
passes this test (verified in Nightly) and Chrome does not.
(Actually a small change is required to the test to make Firefox
pass it, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1452528)

Currently it only tests shared worker but dedicated worker can
be added in a follow-up patch.

Bug: 829720
Change-Id: Id3b1ea8b952760be0ef9917f2c6a3afe60ca1fb5
Reviewed-on: https://chromium-review.googlesource.com/999241
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549125}

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 6fe36d7 into master Apr 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-999241 branch Apr 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment