New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch: align about:blank handling with the standard #10421

Merged
merged 3 commits into from Apr 16, 2018

Conversation

Projects
None yet
3 participants
@annevk
Member

annevk commented Apr 11, 2018

@wpt-pr-bot wpt-pr-bot added the fetch label Apr 11, 2018

@wpt-pr-bot wpt-pr-bot requested review from jdm, mnot, youennf and yutakahirano Apr 11, 2018

@annevk annevk requested a review from foolip Apr 15, 2018

@foolip

foolip approved these changes Apr 15, 2018

Just one nit

cut += " (" + method + ")"
desc = "Fetching " + url.substring(0, 40) + cut + " is OK"
}
function checkKoUrl(url, method) {

This comment has been minimized.

@foolip

foolip Apr 15, 2018

Contributor

This isn't new, but having read the whole test and scratched my head I have no idea what "KO" means, probably "not OK" given the promise_rejects bit. Can you add a comment?

@annevk annevk merged commit fa62ac0 into master Apr 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@annevk annevk deleted the annevk/fetch-about-blank branch Apr 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment