New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test incremental updates with updateWith() #10488

Merged
merged 2 commits into from Apr 25, 2018

Conversation

Projects
None yet
5 participants
@marcoscaceres
Contributor

marcoscaceres commented Apr 16, 2018

@marcoscaceres

This comment has been minimized.

Contributor

marcoscaceres commented Apr 16, 2018

@MSFTkihans once these merge, it would be great if you can confirm if they work in Edge.

@rsolomakhin, these are all fail in Chrome unfortunately.

@marcoscaceres

This comment has been minimized.

Contributor

marcoscaceres commented Apr 16, 2018

@mnoorenberghe, unfortunately, it doesn't seem we have enough UI yet in Firefox Nightly to check these... close tho :)

@marcoscaceres

This comment has been minimized.

Contributor

marcoscaceres commented Apr 16, 2018

@edenchuang, you might want to just double check in Gecko if these would work as expected nevertheless.

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 16, 2018

Build PASSED

Started: 2018-04-16 11:38:14
Finished: 2018-04-16 11:44:26

View more information about this build on:

@rsolomakhin

These are all fail in Chrome unfortunately.

No worries! Will fix in Chrome.

@marcoscaceres

This comment has been minimized.

Contributor

marcoscaceres commented Apr 17, 2018

Ok, so, @MSFTkihans, just checked in Edge, and it passes all except the last test with the modifier: neither the new display item is shown, nor is the total updated.

@marcoscaceres marcoscaceres merged commit 63757de into master Apr 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@marcoscaceres marcoscaceres deleted the payments-incremental-updates branch Apr 25, 2018

@marcoscaceres

This comment has been minimized.

Contributor

marcoscaceres commented Apr 25, 2018

Linked from spec.

@MSFTkihans

This comment has been minimized.

MSFTkihans commented Apr 25, 2018

Apologies for my late reply: I was out of the office for a week. I'm a bit behind on this thread: could you clarify which test you're referencing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment