New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement selectable AudioParam rate #10490

Merged
merged 1 commit into from Apr 24, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Collaborator

chromium-wpt-export-bot commented Apr 16, 2018

AudioParam has a new attribute, automationRate, to allow the user to choose whether
the AudioParam is "a-rate" or "k-rate". Add support for setting and getting
the attribute.

Update all AudioParams to support a-rate and k-rate when allowed.

Spec: https://webaudio.github.io/web-audio-api/#dom-audioparam-automationrate
Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/extLjVzLw7s/9XUZvQqcBQAJ

Bug: 828947
Change-Id: Ibb9fe8bc0dedf3cfdcf33727734b5d66e5a7ca2f
Reviewed-on: https://chromium-review.googlesource.com/945076
Commit-Queue: Raymond Toy rtoy@chromium.org
Reviewed-by: Hongchan Choi hongchan@chromium.org
Reviewed-by: Kent Tamura tkent@chromium.org
Cr-Commit-Position: refs/heads/master@{#552965}

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 16, 2018

Build BROKEN

Started: 2018-04-16 15:46:04
Finished: 2018-04-16 15:50:41

Failing Jobs

  • firefox:nightly
  • chrome:dev

View more information about this build on:

@wpt-pr-bot

Already reviewed downstream.

Implement selectable AudioParam rate
AudioParam has a new attribute, automationRate, to allow the user to choose whether
the AudioParam is "a-rate" or "k-rate".  Add support for setting and getting
the attribute.

Update all AudioParams to support a-rate and k-rate when allowed.

Spec: https://webaudio.github.io/web-audio-api/#dom-audioparam-automationrate
Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/extLjVzLw7s/9XUZvQqcBQAJ

Bug: 828947
Change-Id: Ibb9fe8bc0dedf3cfdcf33727734b5d66e5a7ca2f
Reviewed-on: https://chromium-review.googlesource.com/945076
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552965}

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit b1cb30d into master Apr 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-945076 branch Apr 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment