New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Ahem for Safari on Sauce #10491

Merged
merged 1 commit into from Apr 18, 2018

Conversation

Projects
None yet
5 participants
@jgraham
Contributor

jgraham commented Apr 16, 2018

This just gets the latest master version of the font; we could change
things to get the version for the current revision, but it isn't
necessarily worth the extra complexity given how rarely this changes.


This change is Reviewable

Install Ahem for Safari on Sauce
This just gets the latest master version of the font; we could change
things to get the version for the current revision, but it isn't
necessarily worth the extra complexity given how rarely this changes.
@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 16, 2018

Build PASSED

Started: 2018-04-16 16:39:15
Finished: 2018-04-16 16:49:18

View more information about this build on:

@jugglinmike

This comment has been minimized.

Contributor

jugglinmike commented Apr 16, 2018

I started work on this last week, and while I got things working in Edge, I haven't been able to do the same in macOS/Safari

master...bocoup:gh-9205-ahem-sauce

Your patch seems functionally equivalent, so I'm not sure what's going wrong. Just this morning, I got my hands on a MacBook Pro to experiment locally, so I'll see if I can get more detail that way.

@@ -1,2 +1,3 @@
#!/bin/bash
curl https://raw.githubusercontent.com/w3c/web-platform-tests/master/fonts/Ahem.ttf > ~/Library/Fonts/Ahem.ttf

This comment has been minimized.

@gsnedders

gsnedders Apr 16, 2018

Contributor

Can we download files over the tunnel? Does the tunnel already exist at the point the prerun script runs? Because if it does, then we could just download http://web-platform.test:8000/fonts/Ahem.ttf, which would be the right version for the revision being run?

This comment has been minimized.

@jgraham

jgraham Apr 17, 2018

Contributor

Sure, that might be a better appraoch. This one took like 5 minutes to implement and would therefore be good to land in the meantime if only it actually worked :)

@gsnedders

This comment has been minimized.

Contributor

gsnedders commented Apr 16, 2018

@jugglinmike if you have the Edge side working, can we land that?

@jugglinmike

This comment has been minimized.

Contributor

jugglinmike commented Apr 17, 2018

Sure! #10499

@gsnedders gsnedders merged commit 6030898 into master Apr 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gsnedders gsnedders deleted the ahem_safari_sauce branch Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment