New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'vertical-scroll' for programmatic scrolling #10492

Merged
merged 1 commit into from Apr 25, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Collaborator

chromium-wpt-export-bot commented Apr 16, 2018

If 'vertical-scroll' is disabled for an <iframe>, then it should not be
able to affect the vertical scroll position. One way to block is to use
scripted scrolling by calling "element.scrollIntoView()".

To block such frames (whose feature's disabled), programmatic recursive
scroll calls are not forwarded to parent frames. This means if a given

<iframe> is blocked, then all the calls to scrollIntoView() are limited to the scope of frame (i.e., elements becoming visible in the frame). This applies to all the nested <iframe>'s of a disabled frame as well since they would have the feature disabled as part of propagating the container policy.

Link to explainer/design document for "vertical-scroll":
https://docs.google.com/document/d/1qiWelnMlsOHuT_CQ0Zm_qEAf54HS5DhoIvEDHBlfqps/edit?usp=sharing

Bug: 611982
Change-Id: I0e06b399ad890e263128b997cfbb04eb3bdd1494
Reviewed-on: https://chromium-review.googlesource.com/1014191
Reviewed-by: Ian Clelland iclelland@chromium.org
Reviewed-by: Ehsan Karamad ekaramad@chromium.org
Reviewed-by: David Bokan bokan@chromium.org
Commit-Queue: Ehsan Karamad ekaramad@chromium.org
Cr-Commit-Position: refs/heads/master@{#553561}

@wpt-pr-bot

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 16, 2018

Build PASSED

Started: 2018-04-16 17:46:05
Finished: 2018-04-16 17:57:35

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title from [vertical-scroll]: Do not propagate "scrollIntoView()" from frames with 'vertical-scroll' disabled to frames with the feature enabled to [vertical-scroll]: Do not propagate programmatic scroll from disabled to enabled frames. Apr 17, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title from [vertical-scroll]: Do not propagate programmatic scroll from disabled to enabled frames. to 'vertical-scroll' for programmatic scrolling Apr 20, 2018

'vertical-scroll' for programmatic scrolling
If 'vertical-scroll' is disabled for an <iframe>, then it should not be
able to affect the vertical scroll position. One way to block is to use
scripted scrolling by calling "element.scrollIntoView()".

To block such frames (whose feature's disabled), programmatic recursive
scroll calls are not forwarded to parent frames. This means if a given
<iframe> is blocked, then all the calls to scrollIntoView() are limited
to the scope of frame (i.e., elements becoming visible in the frame).
This applies to all the nested <iframe>'s of a disabled frame as well
since they would have the feature disabled as part of propagating the
container policy.

Link to explainer/design document for "vertical-scroll":
https://docs.google.com/document/d/1qiWelnMlsOHuT_CQ0Zm_qEAf54HS5DhoIvEDHBlfqps/edit?usp=sharing

Bug: 611982
Change-Id: I0e06b399ad890e263128b997cfbb04eb3bdd1494
Reviewed-on: https://chromium-review.googlesource.com/1014191
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553561}

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit e9f36aa into master Apr 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1014191 branch Apr 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment