New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed config.json not being used in TestEnvironment #10494

Merged
merged 1 commit into from Apr 17, 2018

Conversation

Projects
None yet
5 participants
@Cactusmachete
Contributor

Cactusmachete commented Apr 16, 2018

Added a check in the TestEnvironment load_config so the config.json overrides the
default config when present.

Closes #8181


This change is Reviewable

@wpt-pr-bot wpt-pr-bot added the infra label Apr 16, 2018

@wpt-pr-bot wpt-pr-bot requested review from gsnedders and jgraham Apr 16, 2018

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 16, 2018

Build BROKEN

Started: 2018-04-16 18:20:29
Finished: 2018-04-16 18:39:17

Failing Jobs

  • tools_unittest in py27

View more information about this build on:

Cactusmachete
Fixed config.json not being used in TestEnvironment
Added a check in the TestEnvironment load_config so it overrides the
default config when present.

Closes #8181
@gsnedders

This comment has been minimized.

Contributor

gsnedders commented Apr 16, 2018

@jgraham r?

AIUI, this has always been a deliberate decision in wptrunner. That said, I'm happy to change the behaviour here provided we make sure we correctly override everything we depend upon later in load_config.

@jgraham

This comment has been minimized.

Contributor

jgraham commented Apr 17, 2018

We had a usecase recently when someone wanted to run two wptrunner instances on different builds on the same machine, so some override makes sense to me.

@jgraham jgraham merged commit 8824132 into web-platform-tests:master Apr 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Cactusmachete Cactusmachete deleted the Cactusmachete:runport branch Apr 17, 2018

@gsnedders

This comment has been minimized.

Contributor

gsnedders commented Apr 17, 2018

We had a usecase recently when someone wanted to run two wptrunner instances on different builds on the same machine, so some override makes sense to me.

@jgraham The override doesn't help because we still override the ports used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment