New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1455282] wdclient] End session if no more windows are open. #10615

Merged
merged 3 commits into from May 1, 2018

Conversation

Projects
None yet
4 participants
@moz-wptsync-bot
Collaborator

moz-wptsync-bot commented Apr 24, 2018

After closing the last top-level browsing context, the session
will be closed too.

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1455282
gecko-commit: e60e61507ef4a95ab2456d13126f6fef9086109a
gecko-integration-branch: autoland
gecko-reviewers: ato


This change is Reviewable

whimboo added some commits Apr 24, 2018

wdclient] End session if no more windows are open.
After closing the last top-level browsing context, the session
will be closed too.

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1455282
gecko-commit: e60e61507ef4a95ab2456d13126f6fef9086109a
gecko-integration-branch: autoland
gecko-reviewers: ato
wdspec] Ignore exceptions when switching to top-level browsing context.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1455282
gecko-commit: 90908c3a6f9ede9a0c541dedecbd74a4a34807e3
gecko-integration-branch: autoland
gecko-reviewers: ato
wdspec] Add tests for Close Window command.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1455282
gecko-commit: 2ec2ee71cc277daf81db6ae6bb21db9495c229b3
gecko-integration-branch: autoland
gecko-reviewers: ato
@wpt-pr-bot

Already reviewed downstream.

@whimboo

This comment has been minimized.

Contributor

whimboo commented Apr 25, 2018

Interesting. Could this be a hang? Sadly I don't see in which test this is happening, and also due to missing time information in the raw log it's hard to say what happened.

@jgraham

This comment has been minimized.

Contributor

jgraham commented Apr 25, 2018

No, it's just a "bug" in the infrastructure. We can't run all the wdspec tests 10times in the 49½ minute window that Travis allows.

@whimboo

This comment has been minimized.

Contributor

whimboo commented Apr 25, 2018

I see. With the slow shutdowns fixed we might have a better chance. Hopefully we can see such an improvement soon.

@jgraham

This comment has been minimized.

Contributor

jgraham commented Apr 25, 2018

I don't think it's really possible to fix without changing the infrastructure. The curent setup allows a time budget of 5 minutes to run the whole wdpsec testsuite if the conftest file changes. That just isn't realistic.

@whimboo

This comment has been minimized.

Contributor

whimboo commented Apr 26, 2018

I see. Are there plans to run tests in chunks or by type?

@jgraham jgraham merged commit a0b8550 into master May 1, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
upstream/gecko Landed on mozilla-central
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment