New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Scroll an element into view" in HTML spec #10828

Merged
merged 4 commits into from Jun 11, 2018

Conversation

@nanto
Contributor

nanto commented May 3, 2018

This is tests for whatwg/html#3131.

(I'm advised to write tests in whatwg/html#3641 (comment))

nanto added some commits May 3, 2018

scrollPathIntoView method of CanvasRenderingContext2D
I use assert_approx_equals here since properties of DOMRect are of type double.

@wpt-pr-bot wpt-pr-bot requested review from jdm, jgraham and zqzhang May 3, 2018

@zcorpan zcorpan self-requested a review May 28, 2018

@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan

zcorpan May 30, 2018

Contributor

html/browsers/browsing-the-web/scroll-to-fragid/scroll-position-vertical-lr.html (and rl) fail in chromium (with "experimental web platform features" enabled). Can you report a bug if there isn't one already?

The 2dcontext tests I think are generated from tools/tests.yaml or some such. Can the new tests be there also?

Contributor

zcorpan commented May 30, 2018

html/browsers/browsing-the-web/scroll-to-fragid/scroll-position-vertical-lr.html (and rl) fail in chromium (with "experimental web platform features" enabled). Can you report a bug if there isn't one already?

The 2dcontext tests I think are generated from tools/tests.yaml or some such. Can the new tests be there also?

@wpt-pr-bot wpt-pr-bot requested a review from gsnedders Jun 6, 2018

@nanto

This comment has been minimized.

Show comment
Hide comment
@nanto

nanto Jun 6, 2018

Contributor

html/browsers/browsing-the-web/scroll-to-fragid/scroll-position-vertical-lr.html (and rl) fail in chromium (with "experimental web platform features" enabled). Can you report a bug if there isn't one already?

I reported for Blink and Gecko.

The 2dcontext tests I think are generated from tools/tests.yaml or some such. Can the new tests be there also?

OK. I changed tests2d.yaml.

Contributor

nanto commented Jun 6, 2018

html/browsers/browsing-the-web/scroll-to-fragid/scroll-position-vertical-lr.html (and rl) fail in chromium (with "experimental web platform features" enabled). Can you report a bug if there isn't one already?

I reported for Blink and Gecko.

The 2dcontext tests I think are generated from tools/tests.yaml or some such. Can the new tests be there also?

OK. I changed tests2d.yaml.

@zcorpan

zcorpan approved these changes Jun 6, 2018

@fserb

fserb approved these changes Jun 11, 2018

lgtm

@zcorpan zcorpan merged commit 32f74fe into web-platform-tests:master Jun 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment