Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Fonts parsing tests #11469

Closed

Conversation

@ewilligers
Copy link
Contributor

ewilligers commented Jun 12, 2018

Test parsing and serialization of CSS Fonts 3 properties
https://drafts.csswg.org/css-fonts/

@wpt-pr-bot wpt-pr-bot requested review from drott, litherum and svgeesus Jun 12, 2018
test_valid_value("font-family", "Helvetica, Verdana");
test_valid_value("font-family", "serif");
test_valid_value("font-family", "serif, sans-serif, cursive, fantasy, monospace");

This comment has been minimized.

Copy link
@svgeesus

svgeesus Jun 12, 2018

Contributor

Not a blocker, but would be great to see a related test for Fonts 4 with the larger list of generic families

This comment has been minimized.

Copy link
@ewilligers

ewilligers Sep 5, 2018

Author Contributor

People familiar with CSS Fonts 4 can add test cases as a later PR.

Other comments have been addressed.

Copy link
Contributor

svgeesus left a comment

For all tests, please change

<link rel="help" href="https://drafts.csswg.org/css-fonts/

to

<link rel="help" href="https://www.w3.org/TR/css-fonts-3/

This will allow the CSS test harness to pick up these tests, annotate each section of the draft with links to the tests for that section, and update the test reports.

It also means we can clearly indicate these are Fonts 3 tests (for example Fonts 4 has a larger set of generic font families, among many other changes)

Thanks!

Copy link
Contributor

svgeesus left a comment

Overall, a great set of tests. Please see detailed comments.

<html>
<head>
<meta charset="utf-8">
<title>CSS Fonts Level 3: parsing font-variant-alternates with invalid values</title>

This comment has been minimized.

Copy link
@svgeesus

svgeesus Jun 12, 2018

Contributor

Please change the font-variant-alternates tests to Fonts 4. The CSS WG resolved to move this feature from Fonts 3 to Fonts 4, as there is currently only one implementation. (the spec edits are pending on me, hope to get them done before the CSS f2f in Sydney).

<html>
<head>
<meta charset="utf-8">
<title>CSS Fonts Level 3: parsing font-variant with valid values</title>

This comment has been minimized.

Copy link
@svgeesus

svgeesus Jun 12, 2018

Contributor

Please remove the font-variant-alternates values from this test (moved from Fonts 3 to Fonts 4)

<title>CSS Fonts Level 3: parsing font-weight with invalid values</title>
<link rel="author" title="Eric Willigers" href="mailto:ericwilligers@chromium.org">
<link rel="help" href="https://drafts.csswg.org/css-fonts/#font-weight-prop">
<meta name="assert" content="font-weight supports only the grammar 'normal | bold | bolder | lighter | 100 | 200 | 300 | 400 | 500 | 600 | 700 | 800 | 900'.">

This comment has been minimized.

Copy link
@svgeesus

svgeesus Jun 12, 2018

Contributor

Thanks for not testing values like font-weight: 345 which are invalid in Fonts 3 but will be valid in Fonts 4.
This test looks good.

Eric Willigers and others added 4 commits Apr 28, 2018
Test parsing and serialization of CSS Fonts 3 properties
https://drafts.csswg.org/css-fonts/
The font-variant-alternates property is moving to CSS Fonts 4.
@ewilligers ewilligers force-pushed the ewilligers:font3-parsing-tests branch from e0de81a to 2bf6ca6 Sep 5, 2018
@ewilligers ewilligers closed this Jul 11, 2019
@ewilligers ewilligers deleted the ewilligers:font3-parsing-tests branch Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.