Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the SVG IDL file #11796

Merged
merged 2 commits into from Jul 30, 2018

Conversation

@lukebjerring
Copy link
Contributor

commented Jul 4, 2018

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@lukebjerring lukebjerring added this to In progress in Auto-import IDL files Jul 4, 2018

lukebjerring added a commit to lukebjerring/fxtf-drafts that referenced this pull request Jul 4, 2018

Correct inclusion of SVGURIReference
It's an `interface mixin`, not an `interface`, so the operator is `includes` not `implements`.

Found this when cleaning up the SVG deps for web-platform-tests/wpt#11796
@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2018

Equivalent changes in Chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/1126498

EDIT: Test results . Note that the big reduction in the number of tests for SVG is due to all of the duplicated content which lives in filter-effects.idl, which is (now) tested separately.

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-SVG branch 2 times, most recently from fc9f899 to ff389b3 Jul 13, 2018

@lukebjerring lukebjerring moved this from In progress to To do in Auto-import IDL files Jul 28, 2018

@lukebjerring lukebjerring moved this from To do to In progress in Auto-import IDL files Jul 28, 2018

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-SVG branch from ff389b3 to a9812be Jul 28, 2018

@wpt-pr-bot wpt-pr-bot requested review from annevk and removed request for boggydigital Jul 28, 2018

@lukebjerring lukebjerring requested a review from foolip Jul 28, 2018

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-SVG branch from a9812be to 0393028 Jul 30, 2018

Luke Bjerring

@lukebjerring lukebjerring force-pushed the lukebjerring:idl-file-updates-SVG branch from 0393028 to c6bd3b4 Jul 30, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2018

@foolip - I've dropped the changes which update tests that refer to SVG, and we'll do that in a follow-up PR.

@foolip

foolip approved these changes Jul 30, 2018

@foolip foolip merged commit 24c4f1e into web-platform-tests:master Jul 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Auto-import IDL files automation moved this from In progress to Done Jul 30, 2018

@lukebjerring lukebjerring deleted the lukebjerring:idl-file-updates-SVG branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.