Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up IDL tests which reference SVG #12225

Merged
merged 11 commits into from Jul 31, 2018

Conversation

@lukebjerring
Copy link
Contributor

commented Jul 30, 2018

Follow-up from #11796 to import the SVGElement interface properly.

@pwnall

pwnall approved these changes Jul 30, 2018

Copy link
Contributor

left a comment

cookie-store/ change LGTM

@foolip

foolip approved these changes Jul 30, 2018

Copy link
Contributor

left a comment

LGTM % load event thing

idlArray.add_untested_idls(dom + svg + cssom + uievents + touchevents);
idlArray.add_idls(html);
promise_test(async () => {
await new Promise(resolve => { addEventListener('load', resolve); })

This comment has been minimized.

Copy link
@foolip

foolip Jul 30, 2018

Contributor

Whether this is needed I don't know, but to avoid the extra test (now implicitly called "HTML IDL tests"?) can the await part be moved into the async setup of idl_test? (The even listener itself needs to be added here, since otherwise the fetches and the load event will be racing.)

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Jul 31, 2018

Author Contributor

Done.

@wpt-pr-bot wpt-pr-bot requested a review from svgeesus Jul 30, 2018

@lukebjerring lukebjerring force-pushed the lukebjerring:SVG-idl-tests branch from 8cb919a to 07981c1 Jul 31, 2018

@lukebjerring lukebjerring merged commit d533edc into web-platform-tests:master Jul 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Auto-import IDL files automation moved this from In progress to Done Jul 31, 2018

@lukebjerring lukebjerring deleted the lukebjerring:SVG-idl-tests branch Jul 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.