Deflake timeout-multiple-fetches.html #12474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 14, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1174209
branch
from
164ce21
to
03ff5f9
Compare
The external/wpt/xhr/timeout-multiple-fetches.html layout test was flaky due to a race condition. Adjust the timeout to improve the probability of the right side winning the race. Also add a uuid to the URL to stop preflight caching from breaking the test. BUG=871578 Change-Id: I76056f7dadc789289755c35f6b6b9d8ae86c1441 Reviewed-on: https://chromium-review.googlesource.com/1174209 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#586610}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1174209
branch
from
03ff5f9
to
ede4cd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The external/wpt/xhr/timeout-multiple-fetches.html layout test was flaky due to
a race condition. Adjust the timeout to improve the probability of the right
side winning the race.
Also add a uuid to the URL to stop preflight caching from breaking the test.
BUG=871578
Change-Id: I76056f7dadc789289755c35f6b6b9d8ae86c1441
Reviewed-on: https://chromium-review.googlesource.com/1174209
Commit-Queue: Adam Rice ricea@chromium.org
Reviewed-by: Yutaka Hirano yhirano@chromium.org
Cr-Commit-Position: refs/heads/master@{#586610}