New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML: Add manual accessibility tests for fieldset #12691

Open
wants to merge 10 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@zcorpan
Contributor

zcorpan commented Aug 27, 2018

No description provided.

@zcorpan zcorpan requested a review from emilio Aug 27, 2018

@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan

zcorpan Aug 29, 2018

Contributor

If https://github.com/WICG/aom/blob/gh-pages/explainer.md#full-introspection-of-an-accessibility-tree---computedaccessiblenode is implemented, it could be used by these tests as normal testharness.js tests.

Contributor

zcorpan commented Aug 29, 2018

If https://github.com/WICG/aom/blob/gh-pages/explainer.md#full-introspection-of-an-accessibility-tree---computedaccessiblenode is implemented, it could be used by these tests as normal testharness.js tests.

@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan

zcorpan Sep 2, 2018

Contributor

I see accname/ has some tests for accessible name (but not for fieldset), and although the tests are marked as manual, they have some script to formalize the expected result. I'm not familiar with that. @halindrome @joanmarie should these tests be in accname/ with that convention? How are those tests run?

Contributor

zcorpan commented Sep 2, 2018

I see accname/ has some tests for accessible name (but not for fieldset), and although the tests are marked as manual, they have some script to formalize the expected result. I'm not familiar with that. @halindrome @joanmarie should these tests be in accname/ with that convention? How are those tests run?

@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan
Contributor

zcorpan commented Sep 7, 2018

@joanmarie

This comment has been minimized.

Show comment
Hide comment
@joanmarie

joanmarie Sep 12, 2018

Contributor

The tests are run via tools created by the ARIA working group which we hope to integrate into WPT, but which are not yet ready for general consumption due to bugs, lack of documentation, etc.

As for where the tests should live, we should get @stevefaulkner and @scottaohara to chime in. The HTML AAM has normative content regarding Accessible Name calculation specific to HTML and which overrides what is in the Acc Name spec.

Contributor

joanmarie commented Sep 12, 2018

The tests are run via tools created by the ARIA working group which we hope to integrate into WPT, but which are not yet ready for general consumption due to bugs, lack of documentation, etc.

As for where the tests should live, we should get @stevefaulkner and @scottaohara to chime in. The HTML AAM has normative content regarding Accessible Name calculation specific to HTML and which overrides what is in the Acc Name spec.

@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan

zcorpan Sep 12, 2018

Contributor

OK, thank you. Maybe we can leave these tests as manual until those tools are ready?

Contributor

zcorpan commented Sep 12, 2018

OK, thank you. Maybe we can leave these tests as manual until those tools are ready?

@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan

zcorpan Sep 17, 2018

Contributor

@mcking65 are you able to take a look at this?

Contributor

zcorpan commented Sep 17, 2018

@mcking65 are you able to take a look at this?

@asurkov

overall it looks good, sorry it took that long

Show outdated Hide outdated html/semantics/forms/the-fieldset-element/accessibility/aria-manual.html Outdated
Show outdated Hide outdated html/semantics/forms/the-fieldset-element/accessibility/aria-manual.html Outdated
</style>
<fieldset>
<div>
<legend>Foo</legend>

This comment has been minimized.

@asurkov

asurkov Oct 18, 2018

According to HTML spec [1], legend has to be a first child of fieldset. So you're right the browsers shouldn't pick up accessible name from a legend, which is not a direct child. I'd be nice to have a comment in the test or extend <title> to reflect this.

[1] https://html.spec.whatwg.org/multipage/form-elements.html#the-legend-element

@asurkov

asurkov Oct 18, 2018

According to HTML spec [1], legend has to be a first child of fieldset. So you're right the browsers shouldn't pick up accessible name from a legend, which is not a direct child. I'd be nice to have a comment in the test or extend <title> to reflect this.

[1] https://html.spec.whatwg.org/multipage/form-elements.html#the-legend-element

This comment has been minimized.

@zcorpan

zcorpan Oct 18, 2018

Contributor

That is an authoring conformance requirement. The UA conformance requirement is

https://w3c.github.io/html-aam/#fieldset-element-accessible-name-computation

step 2

@zcorpan

zcorpan Oct 18, 2018

Contributor

That is an authoring conformance requirement. The UA conformance requirement is

https://w3c.github.io/html-aam/#fieldset-element-accessible-name-computation

step 2

<!doctype html>
<title>fieldset accessibility test: legend child display: none</title>
<style>
legend > span { display: none; }

This comment has been minimized.

@asurkov

asurkov Oct 18, 2018

I'd say the test is not legend specific, but it's ok to have it if you want

@asurkov

asurkov Oct 18, 2018

I'd say the test is not legend specific, but it's ok to have it if you want

<!doctype html>
<title>fieldset accessibility test: legend role=group aria-labelledby=fieldset</title>
<fieldset id=fieldset>
<legend role=group aria-labelledby=fieldset>Foo</legend>

This comment has been minimized.

@asurkov

asurkov Oct 18, 2018

a tricky one, the output looks reasonable, but I didn't run it through the spec name computation alg

@asurkov

asurkov Oct 18, 2018

a tricky one, the output looks reasonable, but I didn't run it through the spec name computation alg

This comment has been minimized.

@zcorpan

zcorpan Oct 18, 2018

Contributor

Yeah the spec side is pretty messy. I filed an issue but can't find it now. Basically I think accname should have hooks for html-aam to use when defining fieldset/legend.

@zcorpan

zcorpan Oct 18, 2018

Contributor

Yeah the spec side is pretty messy. I filed an issue but can't find it now. Basically I think accname should have hooks for html-aam to use when defining fieldset/legend.

<title>fieldset accessibility test: multiple legends</title>
<fieldset>
<legend>Foo</legend>
<legend>Bar</legend>

This comment has been minimized.

@asurkov

asurkov Oct 18, 2018

a good one, might be worth to have a test where legend is not a first child

@asurkov

asurkov Oct 18, 2018

a good one, might be worth to have a test where legend is not a first child

Show outdated Hide outdated ...emantics/forms/the-fieldset-element/accessibility/shadow-dom-manual.html Outdated
<!doctype html>
<title>fieldset accessibility test: legend visibility: hidden</title>
<style>
legend { visibility: hidden; }

This comment has been minimized.

@asurkov

asurkov Oct 18, 2018

might be worth to have display:none/visibility:hidden placed on fieldset element. Also might worth testing visibility:collapsed and visibility:visible

@asurkov

asurkov Oct 18, 2018

might be worth to have display:none/visibility:hidden placed on fieldset element. Also might worth testing visibility:collapsed and visibility:visible

@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan

zcorpan Oct 18, 2018

Contributor

I can't find the spec for accessible name and descriptions anymore... w3c/accname#34

Contributor

zcorpan commented Oct 18, 2018

I can't find the spec for accessible name and descriptions anymore... w3c/accname#34

@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan

zcorpan Oct 18, 2018

Contributor

OK addressed comments, thank you @asurkov

Contributor

zcorpan commented Oct 18, 2018

OK addressed comments, thank you @asurkov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment