Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly improve AudioBuffer resampling #12887

Merged
merged 1 commit into from Sep 7, 2018

Conversation

Projects
None yet
2 participants
@chromium-wpt-export-bot
Copy link
Collaborator

commented Sep 6, 2018

Use simple linear extrapolation to resample the data when we reach the
end of the buffer. Previously, the last sample would just be repeated
enough times.

Manually verified that the test passes on Firefox (nightly) and fails
on Chrome without this CL.

Bug: 881119
Test: the-audiobuffersourcenode-interface/buffer-resampling.html
Change-Id: I1eb6ee089aa5477e03ff7184eb974f769b739528
Reviewed-on: https://chromium-review.googlesource.com/1211910
Commit-Queue: Raymond Toy rtoy@chromium.org
Reviewed-by: Hongchan Choi hongchan@chromium.org
Cr-Commit-Position: refs/heads/master@{#589529}

@wpt-pr-bot
Copy link
Collaborator

left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1211910 branch from fdc0dd5 to e7266e1 Sep 6, 2018

Raymond Toy Chrome-bot
Slightly improve AudioBuffer resampling
Use simple linear extrapolation to resample the data when we reach the
end of the buffer.  Previously, the last sample would just be repeated
enough times.

Manually verified that the test passes on Firefox (nightly) and fails
on Chrome without this CL.

Bug: 881119
Test: the-audiobuffersourcenode-interface/buffer-resampling.html
Change-Id: I1eb6ee089aa5477e03ff7184eb974f769b739528
Reviewed-on: https://chromium-review.googlesource.com/1211910
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589529}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1211910 branch from e7266e1 to 2a490cf Sep 7, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 8764370 into master Sep 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1211910 branch Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.