Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add several tests to check scroll behavior smooth/instant #13049

Merged
merged 3 commits into from Sep 19, 2018

Conversation

Projects
None yet
3 participants
@fred-wang
Copy link
Contributor

commented Sep 18, 2018

No description provided.

@fred-wang

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2018

@alijuma
Copy link
Contributor

left a comment

These tests look great overall! I know this is a really tricky spec to write good non-flaky tests and the approach taken here seems solid to me.

One request: can we give the tests more descriptive names? So scroll-behavior-default.html instead of scroll-behavior-001.html, scroll-behavior-subframe.html instead of scroll-behavior-003.html, etc.? It just makes it easier to understand a list of passing/failing tests without having to go read each one.

Show resolved Hide resolved css/cssom-view/scroll-behavior-005.html Outdated
Show resolved Hide resolved css/cssom-view/scroll-behavior-006.html Outdated

fred-wang added some commits Sep 19, 2018

Address Ali's review feedback ; use Map instead of Object to track sc…
…roll positions, improve scrollIntoView test for nested boxes.
Add tests for Element.scroll() and Window.scroll* APIs (even if they …
…are suposed to just behave the same as other already tested APIs).
@fred-wang

This comment has been minimized.

Copy link
Contributor Author

commented Sep 19, 2018

@alijuma I've addressed the review comments. I improved the scrollIntoView tests and added some tests for Window.scroll* and Element.scroll() too.

@alijuma
Copy link
Contributor

left a comment

Thanks!

@alijuma alijuma merged commit 0e4ff38 into master Sep 19, 2018

2 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@fred-wang fred-wang deleted the scroll-behavior branch Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.