Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[service-workers] Refactor to use async cleanup #13165
Previously, many tests un-registered service workers only after all
This patch is not intended to influence test results. To verify that, I used
Chromium with patch applied:
Firefox with patch applied:
The discrepancy in Firefox is expected. In
I've attempted to ease the review process by splitting the work across a few
referenced this pull request
Sep 25, 2018
Sorry for the review delay. I didn't have an effective system for receiving GitHub reviews in my inbox. This is great. Thank you for all your work adding async cleanup and for converting these tests.
This patch is fine as-is. One observation is we sometimes remove frames inline and sometimes in add_cleanup. I think add_cleanup is better to isolate promise_tests from each other. We've also tried to remove the frames before calling unregister, as it makes it more likely for the service worker to actually get deactivated, since otherwise it waits for all clients to close. But that's sometimes inconvenient to code.