Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Inherit the navigation initiator when navigating instead of the parent/opener" #14247

Merged
merged 1 commit into from Nov 27, 2018

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

This reverts commit 108147dfd1ea159fd3632ef92ccc4ab8952980c7.

Reason for revert:
FindIt suggests a 74% chance that this is the cause of the following issues:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/26833

Original change's description:

Inherit the navigation initiator when navigating instead of the parent/opener

Spec PR: w3c/webappsec-csp#358

Bug: 905301, 894228, 836148
Change-Id: I43ada2266d42d1cd56dbe3c6dd89d115e878a83a
Reviewed-on: https://chromium-review.googlesource.com/c/1314633
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610850}

TBR=mkwst@chromium.org,andypaicu@chromium.org

Change-Id: If3ccf72cf8a4285926429f2855f32c1b0c606c5b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 905301, 894228, 836148
Reviewed-on: https://chromium-review.googlesource.com/c/1351285
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610930}

…he parent/opener"

This reverts commit 108147dfd1ea159fd3632ef92ccc4ab8952980c7.

Reason for revert:
FindIt suggests a 74% chance that this is the cause of the following issues:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/26833

Original change's description:
> Inherit the navigation initiator when navigating instead of the parent/opener
>
> Spec PR: w3c/webappsec-csp#358
>
> Bug: 905301, 894228, 836148
> Change-Id: I43ada2266d42d1cd56dbe3c6dd89d115e878a83a
> Reviewed-on: https://chromium-review.googlesource.com/c/1314633
> Commit-Queue: Andy Paicu <andypaicu@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610850}

TBR=mkwst@chromium.org,andypaicu@chromium.org

Change-Id: If3ccf72cf8a4285926429f2855f32c1b0c606c5b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 905301, 894228, 836148
Reviewed-on: https://chromium-review.googlesource.com/c/1351285
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610930}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 681b7a2 into master Nov 27, 2018
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-d72a833dad branch November 27, 2018 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants