Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change web platform test with mouse inputs under "pinterevents/" #14694

Merged
merged 1 commit into from Jan 21, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

commented Jan 2, 2019

Use test_driver Actions class in the web platform tests with mouse
inputs in "pinterevents/" to simulate mouse inputs to make the tests
pass on wpt serve.

Bug: 606367
Change-Id: I2f00c3195fafb8bc600250631106cd9eabe79b90
Reviewed-on: https://chromium-review.googlesource.com/c/1383330
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619697}

@wpt-pr-bot
Copy link
Collaborator

left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1383330 branch 2 times, most recently from ef43c14 to 85ba569 Jan 2, 2019

Change web platform test with mouse inputs under "pinterevents/"
Use test_driver Actions class in the web platform tests with mouse
inputs in "pinterevents/" to simulate mouse inputs to make the tests
pass on wpt serve.

Bug: 606367
Change-Id: I2f00c3195fafb8bc600250631106cd9eabe79b90
Reviewed-on: https://chromium-review.googlesource.com/c/1383330
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619697}
@Hexcles

This comment has been minimized.

Copy link
Member

commented Jan 3, 2019

@SummerLW pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html looks weird. It's reported to pass 20 out of 10 times. Did you have two subtests with the same name?

@Hexcles

This comment has been minimized.

Copy link
Member

commented Jan 21, 2019

Force-merging this PR as https://chromium-review.googlesource.com/c/chromium/src/+/1424219 will likely fix the flakiness.

@Hexcles Hexcles merged commit f4c7d84 into master Jan 21, 2019

3 of 4 checks passed

Taskcluster (pull_request) TaskGroup: failure
Details
Azure Pipelines Build #20190103.29 succeeded
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gsnedders gsnedders deleted the chromium-export-cl-1383330 branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.