Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated fetch/sec-metadata to reflect new Sec-Fetch spec. #14771

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@empijei
Copy link

commented Jan 9, 2019

Expected values for "Sec-Fetch-Mode" will be added in a future change.

Reference can be found here.

Updated fetch/sec-metadata to reflect new Sec-Fetch spec.
Expected values for "Sec-Fetch-Mode" will be added in a future change.
@mikewest

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2019

This is looking great, thank you. As discussed elsewhere, I'm going to pull this into https://chromium-review.googlesource.com/c/chromium/src/+/1402448 so I can run it through Chromium's test suite before landing it. I really appreciate the work!

@mikewest mikewest assigned mikewest and unassigned youennf Jan 10, 2019

chromium-wpt-export-bot added a commit that referenced this pull request Jan 10, 2019

Split `Sec-Metadata` into `Sec-Fetch-*`.
As of [1], we've split the single `Sec-Metadata` header into multiple
headers: `Sec-Fetch-Dist`, `Sec-Fetch-Site`, and `Sec-Fetch-User`. This
patch does that work in Chromium.

The spec change also added `Sec-Fetch-Mode`. We'll add that
functionality to Chromium in a future CL.

Test changes pulled from clap@'s excellent PR at
#14771

[1]: w3c/webappsec-fetch-metadata@105103d

Bug: 843478
Change-Id: I7654d5e823ad813682ac3eb244bbc244a322e6ca
@mikewest

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2019

Closing this in favor of the auto-generated #14792.

@mikewest mikewest closed this Jan 10, 2019

chromium-wpt-export-bot added a commit that referenced this pull request Jan 10, 2019

Split `Sec-Metadata` into `Sec-Fetch-*`.
As of [1], we've split the single `Sec-Metadata` header into multiple
headers: `Sec-Fetch-Dist`, `Sec-Fetch-Site`, and `Sec-Fetch-User`. This
patch does that work in Chromium.

The spec change also added `Sec-Fetch-Mode`, but this patch does not.
We'll add that functionality to Chromium in a future CL.

Test changes pulled from clap@'s excellent PR at
#14771

The test failures are expected: redirect failures are
https://crbug.com/872285, object/embed failures are
https://crbug.com/860510. XSLT failures are WontFix (some
engines support cross-origin XSLT; Blink does not).

[1]: w3c/webappsec-fetch-metadata@105103d

Bug: 843478
Change-Id: I7654d5e823ad813682ac3eb244bbc244a322e6ca

chromium-wpt-export-bot added a commit that referenced this pull request Jan 11, 2019

Split `Sec-Metadata` into `Sec-Fetch-*`.
As of [1], we've split the single `Sec-Metadata` header into multiple
headers: `Sec-Fetch-Dist`, `Sec-Fetch-Site`, and `Sec-Fetch-User`. This
patch does that work in Chromium.

The spec change also added `Sec-Fetch-Mode`, but this patch does not.
We'll add that functionality to Chromium in a future CL.

Test changes pulled from clap@'s excellent PR at
#14771

The test failures are expected: redirect failures are
https://crbug.com/872285, object/embed failures are
https://crbug.com/860510. XSLT failures are WontFix (some
engines support cross-origin XSLT; Blink does not).

[1]: w3c/webappsec-fetch-metadata@105103d

Bug: 843478
Change-Id: I7654d5e823ad813682ac3eb244bbc244a322e6ca

chromium-wpt-export-bot added a commit that referenced this pull request Jan 11, 2019

Split `Sec-Metadata` into `Sec-Fetch-*`.
As of [1], we've split the single `Sec-Metadata` header into multiple
headers: `Sec-Fetch-Dest`, `Sec-Fetch-Site`, and `Sec-Fetch-User`. This
patch does that work in Chromium.

The spec change also added `Sec-Fetch-Mode`, but this patch does not.
We'll add that functionality to Chromium in a future CL.

Test changes pulled from clap@'s excellent PR at
#14771

The test failures are expected: redirect failures are
https://crbug.com/872285, object/embed failures are
https://crbug.com/860510. XSLT failures are WontFix (some
engines support cross-origin XSLT; Blink does not).

[1]: w3c/webappsec-fetch-metadata@105103d

Bug: 843478
Change-Id: I7654d5e823ad813682ac3eb244bbc244a322e6ca

chromium-wpt-export-bot added a commit that referenced this pull request Jan 11, 2019

Split `Sec-Metadata` into `Sec-Fetch-*`.
As of [1], we've split the single `Sec-Metadata` header into multiple
headers: `Sec-Fetch-Dest`, `Sec-Fetch-Site`, and `Sec-Fetch-User`. This
patch does that work in Chromium.

The spec change also added `Sec-Fetch-Mode`, but this patch does not.
We'll add that functionality to Chromium in a future CL.

Test changes pulled from clap@'s excellent PR at
#14771

The test failures are expected: redirect failures are
https://crbug.com/872285, object/embed failures are
https://crbug.com/860510. XSLT failures are WontFix (some
engines support cross-origin XSLT; Blink does not).

[1]: w3c/webappsec-fetch-metadata@105103d

Bug: 843478
Change-Id: I7654d5e823ad813682ac3eb244bbc244a322e6ca

aarongable pushed a commit to chromium/chromium that referenced this pull request Jan 11, 2019

Split `Sec-Metadata` into `Sec-Fetch-*`.
As of [1], we've split the single `Sec-Metadata` header into multiple
headers: `Sec-Fetch-Dest`, `Sec-Fetch-Site`, and `Sec-Fetch-User`. This
patch does that work in Chromium.

The spec change also added `Sec-Fetch-Mode`, but this patch does not.
We'll add that functionality to Chromium in a future CL.

Test changes pulled from clap@'s excellent PR at
web-platform-tests/wpt#14771

The test failures are expected: redirect failures are
https://crbug.com/872285, object/embed failures are
https://crbug.com/860510. XSLT failures are WontFix (some
engines support cross-origin XSLT; Blink does not).

[1]: w3c/webappsec-fetch-metadata@105103d

Bug: 843478
Change-Id: I7654d5e823ad813682ac3eb244bbc244a322e6ca
Reviewed-on: https://chromium-review.googlesource.com/c/1402448
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622145}

chromium-wpt-export-bot added a commit that referenced this pull request Jan 11, 2019

Split `Sec-Metadata` into `Sec-Fetch-*`.
As of [1], we've split the single `Sec-Metadata` header into multiple
headers: `Sec-Fetch-Dest`, `Sec-Fetch-Site`, and `Sec-Fetch-User`. This
patch does that work in Chromium.

The spec change also added `Sec-Fetch-Mode`, but this patch does not.
We'll add that functionality to Chromium in a future CL.

Test changes pulled from clap@'s excellent PR at
#14771

The test failures are expected: redirect failures are
https://crbug.com/872285, object/embed failures are
https://crbug.com/860510. XSLT failures are WontFix (some
engines support cross-origin XSLT; Blink does not).

[1]: w3c/webappsec-fetch-metadata@105103d

Bug: 843478
Change-Id: I7654d5e823ad813682ac3eb244bbc244a322e6ca
Reviewed-on: https://chromium-review.googlesource.com/c/1402448
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622145}

chromium-wpt-export-bot added a commit that referenced this pull request Jan 11, 2019

Split `Sec-Metadata` into `Sec-Fetch-*`.
As of [1], we've split the single `Sec-Metadata` header into multiple
headers: `Sec-Fetch-Dest`, `Sec-Fetch-Site`, and `Sec-Fetch-User`. This
patch does that work in Chromium.

The spec change also added `Sec-Fetch-Mode`, but this patch does not.
We'll add that functionality to Chromium in a future CL.

Test changes pulled from clap@'s excellent PR at
#14771

The test failures are expected: redirect failures are
https://crbug.com/872285, object/embed failures are
https://crbug.com/860510. XSLT failures are WontFix (some
engines support cross-origin XSLT; Blink does not).

[1]: w3c/webappsec-fetch-metadata@105103d

Bug: 843478
Change-Id: I7654d5e823ad813682ac3eb244bbc244a322e6ca
Reviewed-on: https://chromium-review.googlesource.com/c/1402448
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622145}

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 5, 2019

Bug 1523562 [wpt PR 14792] - Split `Sec-Metadata` into `Sec-Fetch-*`.…
…, a=testonly

Automatic update from web-platform-tests
Split `Sec-Metadata` into `Sec-Fetch-*`.

As of [1], we've split the single `Sec-Metadata` header into multiple
headers: `Sec-Fetch-Dest`, `Sec-Fetch-Site`, and `Sec-Fetch-User`. This
patch does that work in Chromium.

The spec change also added `Sec-Fetch-Mode`, but this patch does not.
We'll add that functionality to Chromium in a future CL.

Test changes pulled from clap@'s excellent PR at
web-platform-tests/wpt#14771

The test failures are expected: redirect failures are
https://crbug.com/872285, object/embed failures are
https://crbug.com/860510. XSLT failures are WontFix (some
engines support cross-origin XSLT; Blink does not).

[1]: w3c/webappsec-fetch-metadata@105103d

Bug: 843478
Change-Id: I7654d5e823ad813682ac3eb244bbc244a322e6ca
Reviewed-on: https://chromium-review.googlesource.com/c/1402448
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622145}

--

wpt-commits: 2d42384cf21efd71843295d319c1bab85b3acf4a
wpt-pr: 14792

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Feb 6, 2019

Bug 1523562 [wpt PR 14792] - Split `Sec-Metadata` into `Sec-Fetch-*`.…
…, a=testonly

Automatic update from web-platform-tests
Split `Sec-Metadata` into `Sec-Fetch-*`.

As of [1], we've split the single `Sec-Metadata` header into multiple
headers: `Sec-Fetch-Dest`, `Sec-Fetch-Site`, and `Sec-Fetch-User`. This
patch does that work in Chromium.

The spec change also added `Sec-Fetch-Mode`, but this patch does not.
We'll add that functionality to Chromium in a future CL.

Test changes pulled from clap@'s excellent PR at
web-platform-tests/wpt#14771

The test failures are expected: redirect failures are
https://crbug.com/872285, object/embed failures are
https://crbug.com/860510. XSLT failures are WontFix (some
engines support cross-origin XSLT; Blink does not).

[1]: w3c/webappsec-fetch-metadata@105103d

Bug: 843478
Change-Id: I7654d5e823ad813682ac3eb244bbc244a322e6ca
Reviewed-on: https://chromium-review.googlesource.com/c/1402448
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622145}

--

wpt-commits: 2d42384cf21efd71843295d319c1bab85b3acf4a
wpt-pr: 14792

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 7, 2019

Bug 1523562 [wpt PR 14792] - Split `Sec-Metadata` into `Sec-Fetch-*`.…
…, a=testonly

Automatic update from web-platform-tests
Split `Sec-Metadata` into `Sec-Fetch-*`.

As of [1], we've split the single `Sec-Metadata` header into multiple
headers: `Sec-Fetch-Dest`, `Sec-Fetch-Site`, and `Sec-Fetch-User`. This
patch does that work in Chromium.

The spec change also added `Sec-Fetch-Mode`, but this patch does not.
We'll add that functionality to Chromium in a future CL.

Test changes pulled from clap@'s excellent PR at
web-platform-tests/wpt#14771

The test failures are expected: redirect failures are
https://crbug.com/872285, object/embed failures are
https://crbug.com/860510. XSLT failures are WontFix (some
engines support cross-origin XSLT; Blink does not).

[1]: w3c/webappsec-fetch-metadata@105103d

Bug: 843478
Change-Id: I7654d5e823ad813682ac3eb244bbc244a322e6ca
Reviewed-on: https://chromium-review.googlesource.com/c/1402448
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622145}

--

wpt-commits: 2d42384cf21efd71843295d319c1bab85b3acf4a
wpt-pr: 14792

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Feb 8, 2019

Bug 1523562 [wpt PR 14792] - Split `Sec-Metadata` into `Sec-Fetch-*`.…
…, a=testonly

Automatic update from web-platform-tests
Split `Sec-Metadata` into `Sec-Fetch-*`.

As of [1], we've split the single `Sec-Metadata` header into multiple
headers: `Sec-Fetch-Dest`, `Sec-Fetch-Site`, and `Sec-Fetch-User`. This
patch does that work in Chromium.

The spec change also added `Sec-Fetch-Mode`, but this patch does not.
We'll add that functionality to Chromium in a future CL.

Test changes pulled from clap@'s excellent PR at
web-platform-tests/wpt#14771

The test failures are expected: redirect failures are
https://crbug.com/872285, object/embed failures are
https://crbug.com/860510. XSLT failures are WontFix (some
engines support cross-origin XSLT; Blink does not).

[1]: w3c/webappsec-fetch-metadata@105103d

Bug: 843478
Change-Id: I7654d5e823ad813682ac3eb244bbc244a322e6ca
Reviewed-on: https://chromium-review.googlesource.com/c/1402448
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622145}

--

wpt-commits: 2d42384cf21efd71843295d319c1bab85b3acf4a
wpt-pr: 14792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.