Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LazyLoad: Add external web platform tests for the "loading" attribute. #14914

Merged
merged 1 commit into from Jul 12, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Jan 17, 2019

This CL includes tests for:

  • Testing that images and iframes with the attribute loading="lazy" are
    deferred until they come into view
  • Testing that images and iframes with the attribute loading="eager" are
    loaded immediately

Bug: 916260
Change-Id: I323faa31c7683663d0d0136a719cf83c25758ad6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1417117
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676804}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1417117 branch from 731a86d to 69ba0d4 Jan 23, 2019
@bengreenstein bengreenstein referenced this pull request Apr 8, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1417117 branch 2 times, most recently from 3b29d61 to b6b0fd5 Jun 21, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title LazyLoad: Add external web platform tests for the lazyload attribute. LazyLoad: Add external web platform tests for the "loading" attribute. Jun 22, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1417117 branch from b6b0fd5 to 490f60b Jun 22, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1417117 branch 2 times, most recently from 6f16773 to 8230c5d Jul 2, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1417117 branch 2 times, most recently from 00d84a6 to 39546ea Jul 9, 2019
This CL includes tests for:
- Testing that images and iframes with the attribute loading="lazy" are
  deferred until they come into view
- Testing that images and iframes with the attribute loading="eager" are
  loaded immediately

Bug: 916260
Change-Id: I323faa31c7683663d0d0136a719cf83c25758ad6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1417117
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676804}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1417117 branch from 39546ea to 9774518 Jul 12, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 9919d0f into master Jul 12, 2019
15 checks passed
15 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
website-build-and-publish website-build-and-publish
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190712.26 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1417117 branch Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.