Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html,custom-elements: Add tests for HTMLElement.attachInternals() #15123

Merged
merged 2 commits into from Feb 21, 2019

Conversation

@tkent-google
Copy link
Contributor

commented Jan 29, 2019

Issue: w3c/webcomponents#758
Specification PR: whatwg/html#4324

@tkent-google

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

The taskcluster failure is for unstable css/css-font-loading/idlharness.https.html. This PR is unrelated to it.

@lukebjerring

This comment has been minimized.

Copy link
Contributor

commented Jan 29, 2019

Tests look OK. Do you have a PR for the change to the spec? Typically the new IDL method definition will automatically be picked up by the reffy-reports scraper at a later date when that change lands, but it's fine to manually attach the same IDL change to this PR in the meantime - the only concern is that the pipeline may attempt to revert the change if it has not landed.

@domenic
Copy link
Member

left a comment

LGTM with nit!

Not sure what taskcluster's issue is :-/.

assert_true(span instanceof HTMLElement);
assert_throws('InvalidStateError', () => { span.attachInternals(); });
const undefinedCustom = document.createElement('my-element');

This comment has been minimized.

Copy link
@domenic

domenic Jan 30, 2019

Member

This may be a bit clearer if you use undefined-element instead of my-element. Right now I had to look up to see what names you had defined so far and see that only my-element1 was defined, not my-element.

This comment has been minimized.

Copy link
@tkent-google

tkent-google Feb 5, 2019

Author Contributor

Done

@foolip

This comment has been minimized.

Copy link
Contributor

commented Jan 30, 2019

Because html.idl was modified, Taskcluster ran all tests that depend on html.idl. That ran into #14862. The Firefox logs are too get to the end to find the problem :/

@foolip

This comment has been minimized.

Copy link
Contributor

commented Jan 30, 2019

I've tried to fix one of the problems in #15170 if anyone would care to review.

@foolip

This comment has been minimized.

Copy link
Contributor

commented Jan 30, 2019

Filed #15171, but also was finally able to find the cause:

Unstable results

Test Subtest Results Messages
/html/dom/interfaces.https.html?include=(Document|Window) Window interface: window must inherit property "onunload" with the proper type FAIL: 9/10, PASS: 1/10 Unrecognized type EventHandlerNonNull

That's #14254.

In any event, it's OK to merge with the Taskcluster failures on this PR, just ask an admin, like me or @jgraham.

@foolip foolip merged commit 4c70b5a into master Feb 21, 2019

5 of 9 checks passed

Taskcluster (pull_request) TaskGroup: failure
Details
chrome[experimental] wpt.fyi - Chrome results
Details
firefox[experimental] wpt.fyi - Firefox results
Details
safari[experimental] wpt.fyi - Safari results
Details
Azure Pipelines Build #20190205.18 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests (Safari Technology Preview)) affected tests (Safari Technology Preview) succeeded
Details
Azure Pipelines (affected tests without changes (Safari Technology Preview)) affected tests without changes (Safari Technology Preview) succeeded
Details
Travis CI - Pull Request Build Passed
Details

@foolip foolip deleted the tkent-elementinternals branch Feb 21, 2019

chromium-wpt-export-bot added a commit that referenced this pull request Feb 22, 2019

custom-elements: Update CustomElementRegistry.html for 'disabledFeatu…
…res'.

This change is for whatwg/html#4324, and
a follow-up of #15123

Bug: crbug.com/905922
Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa

chromium-wpt-export-bot added a commit that referenced this pull request Feb 26, 2019

custom-elements: Update CustomElementRegistry.html for 'disabledFeatu…
…res'.

This change is for whatwg/html#4324, and
a follow-up of #15123

Bug: crbug.com/905922
Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa
Reviewed-on: https://chromium-review.googlesource.com/c/1482361
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635380}

aarongable pushed a commit to chromium/chromium that referenced this pull request Feb 26, 2019

custom-elements: Update CustomElementRegistry.html for 'disabledFeatu…
…res'.

This change is for whatwg/html#4324, and
a follow-up of web-platform-tests/wpt#15123

Bug: crbug.com/905922
Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa
Reviewed-on: https://chromium-review.googlesource.com/c/1482361
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635380}

chromium-wpt-export-bot added a commit that referenced this pull request Feb 26, 2019

custom-elements: Update CustomElementRegistry.html for 'disabledFeatu…
…res'.

This change is for whatwg/html#4324, and
a follow-up of #15123

Bug: crbug.com/905922
Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa
Reviewed-on: https://chromium-review.googlesource.com/c/1482361
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635380}

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 15, 2019

Bug 1531256 [wpt PR 15516] - custom-elements: Update CustomElementReg…
…istry.html for 'disabledFeatures'., a=testonly

Automatic update from web-platform-tests
custom-elements: Update CustomElementRegistry.html for 'disabledFeatures'.

This change is for whatwg/html#4324, and
a follow-up of web-platform-tests/wpt#15123

Bug: crbug.com/905922
Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa
Reviewed-on: https://chromium-review.googlesource.com/c/1482361
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635380}

--

wpt-commits: 1aa5413b0c0a03d3c93e07d18bf8cc78e19ca611
wpt-pr: 15516

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Mar 16, 2019

Bug 1531256 [wpt PR 15516] - custom-elements: Update CustomElementReg…
…istry.html for 'disabledFeatures'., a=testonly

Automatic update from web-platform-tests
custom-elements: Update CustomElementRegistry.html for 'disabledFeatures'.

This change is for whatwg/html#4324, and
a follow-up of web-platform-tests/wpt#15123

Bug: crbug.com/905922
Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa
Reviewed-on: https://chromium-review.googlesource.com/c/1482361
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635380}

--

wpt-commits: 1aa5413b0c0a03d3c93e07d18bf8cc78e19ca611
wpt-pr: 15516

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 16, 2019

Bug 1531256 [wpt PR 15516] - custom-elements: Update CustomElementReg…
…istry.html for 'disabledFeatures'., a=testonly

Automatic update from web-platform-tests
custom-elements: Update CustomElementRegistry.html for 'disabledFeatures'.

This change is for whatwg/html#4324, and
a follow-up of web-platform-tests/wpt#15123

Bug: crbug.com/905922
Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa
Reviewed-on: https://chromium-review.googlesource.com/c/1482361
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635380}

--

wpt-commits: 1aa5413b0c0a03d3c93e07d18bf8cc78e19ca611
wpt-pr: 15516

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Mar 17, 2019

Bug 1531256 [wpt PR 15516] - custom-elements: Update CustomElementReg…
…istry.html for 'disabledFeatures'., a=testonly

Automatic update from web-platform-tests
custom-elements: Update CustomElementRegistry.html for 'disabledFeatures'.

This change is for whatwg/html#4324, and
a follow-up of web-platform-tests/wpt#15123

Bug: crbug.com/905922
Change-Id: I3eceb5d21ab555c23ed877ded17d359fe004e2aa
Reviewed-on: https://chromium-review.googlesource.com/c/1482361
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635380}

--

wpt-commits: 1aa5413b0c0a03d3c93e07d18bf8cc78e19ca611
wpt-pr: 15516

domenic added a commit to whatwg/html that referenced this pull request May 16, 2019

Custom elements: add element internals
This provides the ElementInternals interface, which can be obtained for
custom elements via the element.attachInternals() method. For now
ElementInternals is empty, but it will gain members in #4383.

This also adds the ability for custom elements to set the
disabledFeatures static property, to disable element internals and
shadow DOM. Some DOM-side infrastructure work there is necessary in
whatwg/dom#760.

Tests:
- web-platform-tests/wpt#15123
- web-platform-tests/wpt#15516
- web-platform-tests/wpt#16853

Fixes w3c/webcomponents#758.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.