Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compositing] Computed value tests #15319

Merged

Conversation

@ewilligers
Copy link
Contributor

ewilligers commented Feb 10, 2019

background-blend-mode, isolation, mix-blend-mode computed values are as specified.
https://drafts.fxtf.org/compositing-1/#property-index

All tests pass with Firefox.

Three background-blend-mode tests fail with Blink/Edge/Safari:
expected "normal, luminosity" but got "normal"
expected "screen, overlay" but got "screen"
expected "color, saturation" but got "color"

@ewilligers

This comment has been minimized.

Copy link
Contributor Author

ewilligers commented Feb 11, 2019

With Blink/Edge/Safari, getComputedStyle()['background-blend-mode'] has as many entries as background-image.

@ewilligers

This comment has been minimized.

Copy link
Contributor Author

ewilligers commented Feb 25, 2019

@plinss please review

@ewilligers

This comment has been minimized.

Copy link
Contributor Author

ewilligers commented May 14, 2019

@nikosandronikos please review

@ewilligers ewilligers requested a review from chrishtr May 25, 2019
@ewilligers

This comment has been minimized.

Copy link
Contributor Author

ewilligers commented May 25, 2019

@chrishtr Would you be happy to be added as a WPT reviewer for compositing?

@ewilligers ewilligers requested a review from emilio Jul 11, 2019
@emilio
emilio approved these changes Jul 11, 2019
@chrishtr

This comment has been minimized.

Copy link

chrishtr commented Jul 11, 2019

Sorry I spaced and missed this comment. I can review in the future, yes.

background-blend-mode, isolation, mix-blend-mode computed values are as specified.
https://drafts.fxtf.org/compositing-1/#property-index

All tests pass with Firefox.

Three background-blend-mode tests fail with Blink/Edge/Safari:
expected "normal, luminosity" but got "normal"
expected "screen, overlay" but got "screen"
expected "color, saturation" but got "color"
@ewilligers ewilligers force-pushed the ewilligers:compositing-computed branch from 4d9cd0b to fae5d5d Jul 12, 2019
@ewilligers ewilligers merged commit d0a227e into web-platform-tests:master Jul 12, 2019
10 checks passed
10 checks passed
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190712.8 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
wpt.fyi - firefox[experimental] Firefox results
Details
@ewilligers ewilligers deleted the ewilligers:compositing-computed branch Jul 12, 2019
natechapin added a commit to natechapin/wpt that referenced this pull request Aug 23, 2019
background-blend-mode, isolation, mix-blend-mode computed values are as specified.
https://drafts.fxtf.org/compositing-1/#property-index

All tests pass with Firefox.

Three background-blend-mode tests fail with Blink/Edge/Safari:
expected "normal, luminosity" but got "normal"
expected "screen, overlay" but got "screen"
expected "color, saturation" but got "color"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.