Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Import Maps] Implement Import Maps v0.5 behind a flag #15371

Merged
merged 1 commit into from Feb 13, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 13, 2019

Design doc: https://docs.google.com/document/d/1vFQzbmxg9ilpg8CT_P8roEYcpTfZ06Q5N4J9-ZQqqZo/edit

This CL implements an initial version of Import Maps that supports

  • Inline import maps (i.e. no src attribute),
  • Layered API/Built-in modules fallback, and
  • Basic bare specifier mapping.

The import maps are behind the flag of LayeredAPI.

Bug: 848607
Change-Id: I31efa6f9ce470375a07592f627b525f48dc2d504
Reviewed-on: https://chromium-review.googlesource.com/c/1449093
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631880}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Implement Import Maps v0.5 behind a flag [Import Maps] Implement Import Maps v0.5 behind a flag Feb 13, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1449093 branch 3 times, most recently from 362ed35 to 96f7605 Compare February 13, 2019 18:13
Design doc: https://docs.google.com/document/d/1vFQzbmxg9ilpg8CT_P8roEYcpTfZ06Q5N4J9-ZQqqZo/edit

This CL implements an initial version of Import Maps that supports
- Inline import maps (i.e. no src attribute),
- Layered API/Built-in modules fallback, and
- Basic bare specifier mapping.

The import maps are behind the flag of LayeredAPI.

Bug: 848607
Change-Id: I31efa6f9ce470375a07592f627b525f48dc2d504
Reviewed-on: https://chromium-review.googlesource.com/c/1449093
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants