SignedExchange: Close response body data pipe on integrity error #15388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 14, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1470355
branch
from
a1f30d2
to
5ee2d90
Compare
This fixes a bug where data pipe for response body was not closed when Signed Exchange has payload integrity error. SourceStreamToDataPipe::OnComplete() attempts to close the pipe by resetting |pending_write_|. But if |source_| is a FilterSourceStream, it still retains a reference to |pending_write_|. We should explicitly call |pending_write_->Complete(0)| to free the pipe on error cases too. Bug: 931955 Change-Id: I63b2470dbb92aa57016c5c71222bcdabe889fd34 Reviewed-on: https://chromium-review.googlesource.com/c/1470355 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#632118}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1470355
branch
from
5ee2d90
to
70a75aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where data pipe for response body was not closed when
Signed Exchange has payload integrity error.
SourceStreamToDataPipe::OnComplete() attempts to close the pipe by
resetting |pending_write_|. But if |source_| is a FilterSourceStream, it
still retains a reference to |pending_write_|. We should explicitly call
|pending_write_->Complete(0)| to free the pipe on error cases too.
Bug: 931955
Change-Id: I63b2470dbb92aa57016c5c71222bcdabe889fd34
Reviewed-on: https://chromium-review.googlesource.com/c/1470355
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632118}