Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Fix 3 cases of break opportunities after nowrap #15509

Merged
merged 1 commit into from Feb 25, 2019

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Copy link
Collaborator

commented Feb 21, 2019

This patch fixes lines to break in the following conditions:

  1. When wrappable elements appear inside of nowrap elements.
  2. When wrappable spaces after nowrap appear inside of nowrap
    elements.
  3. When non-space break opportunities appear after nowrap.

fast/text/whitespace/018.html improves but still doesn't pass.
It doesn't pass in Edge/Gecko, and at least some of what it
expects look questionable. Further investigation is deferred
to future CLs.

Bug: 920177
Change-Id: Ieba4d446b818120f423b87a7f4a44b3c63a9d995
Reviewed-on: https://chromium-review.googlesource.com/c/1477629
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635180}

@wpt-pr-bot
Copy link
Collaborator

left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1477629 branch from f156463 to 23d7450 Feb 25, 2019

[LayoutNG] Fix 3 cases of break opportunities after nowrap
This patch fixes lines to break in the following conditions:
1. When wrappable elements appear inside of nowrap elements.
2. When wrappable spaces after nowrap appear inside of nowrap
   elements.
3. When non-space break opportunities appear after nowrap.

fast/text/whitespace/018.html improves but still doesn't pass.
It doesn't pass in Edge/Gecko, and at least some of what it
expects look questionable. Further investigation is deferred
to future CLs.

Bug: 920177
Change-Id: Ieba4d446b818120f423b87a7f4a44b3c63a9d995
Reviewed-on: https://chromium-review.googlesource.com/c/1477629
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635180}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1477629 branch from 23d7450 to 85c4984 Feb 25, 2019

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 67e1c4c into master Feb 25, 2019

5 of 10 checks passed

Azure Pipelines Build #20190225.108 has failed
Details
Azure Pipelines (affected tests (Safari Technology Preview)) affected tests (Safari Technology Preview) failed
Details
Azure Pipelines (affected tests without changes (Safari Technology Preview)) affected tests without changes (Safari Technology Preview) failed
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
Travis CI - Pull Request Build Passed
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - chrome[experimental] Chrome results
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1477629 branch Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.