Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ChromeDriver] Set key modifiers with mouse actions #15512

Merged
merged 3 commits into from Mar 21, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

commented Feb 22, 2019

When we have keyboard events and mouse events send together, we should
keep the keys that we are pressing now and set them to the mouse events
that are in the same action sequence.

Bug: chromedriver:1897
Change-Id: I700d7a87d3d0a1b45c1588318ab21314aa284417
Reviewed-on: https://chromium-review.googlesource.com/c/1482009
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634700}

--

Follow-up commit also included in this PR:

[wpt] Fix actionsWithKeyPressed.html.ini

actionsWithKeyPressed.html test does not work on both Firefox and
Safari, so I change actionsWithKeyPressed.html.ini to skip both
browsers.

Bug: chromedriver:1897
Change-Id: I86fb1507cf86f2fe209414615b8ea73834456202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529624
Reviewed-by: Navid Zolghadr nzolghadr@chromium.org
Commit-Queue: Lan Wei lanwei@chromium.org
Cr-Commit-Position: refs/heads/master@{#642112}

@wpt-pr-bot
Copy link
Collaborator

left a comment

Already reviewed downstream.

@Hexcles

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

@SummerLW The new test failed unexpectedly on Firefox:

TEST-UNEXPECTED-FAIL | /infrastructure/testdriver/actions/actionsWithKeyPressed.html | TestDriver actions: actions with key pressed - assert_array_equals: lengths differ, expected 3 got 1

@lukebjerring

This comment has been minimized.

@NavidZ

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

@SummerLW the infrastructure/* tests are the ones that need to pass before landing the change in wpt. It is different from other random features like pointerevents/* tests that even if all browsers fail the patch can still land.

Did you test this locally? Did it pass in say Chrome? Note that testing this as part of Chrome try bots is not the same as running wptrun script.

[ChromeDriver] Set key modifiers with mouse actions
When we have keyboard events and mouse events send together, we should
keep the keys that we are pressing now and set them to the mouse events
that are in the same action sequence.

Bug: chromedriver:1897
Change-Id: I700d7a87d3d0a1b45c1588318ab21314aa284417
Reviewed-on: https://chromium-review.googlesource.com/c/1482009
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634700}

@foolip foolip force-pushed the chromium-export-cl-1482009 branch from 1701dc2 to b3f3080 Mar 18, 2019

Fix actionsWithKeyPressed.html.ini
actionsWithKeyPressed.html test does not work on both Firefox and
Safari, so I change actionsWithKeyPressed.html.ini to skip both
browsers.

Bug: chromedriver:1897
Change-Id: I86fb1507cf86f2fe209414615b8ea73834456202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529624
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642112}
@foolip

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

I've pushed https://chromium.googlesource.com/chromium/src/+/73fa2b382e to this PR as well, updating the description to indicate both are included.

@foolip

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

@SummerLW looks like the failure is actually on Chrome Dev, so adding that commit didn't help. Do you expect that the test to begin passing with the next release of ChromeDriver?

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 09f993e into master Mar 21, 2019

6 of 11 checks passed

Azure Pipelines Build #20190321.103 failed
Details
Azure Pipelines (infrastructure/ tests (macOS)) infrastructure/ tests (macOS) failed
Details
Taskcluster (pull_request) TaskGroup: failure
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests (Safari Technology Preview)) affected tests (Safari Technology Preview) succeeded
Details
Azure Pipelines (affected tests without changes (Safari Technology Preview)) affected tests without changes (Safari Technology Preview) succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Travis CI - Pull Request Build Passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1482009 branch Mar 21, 2019

@gsnedders

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

This got landed after we disabled TC being a blocking job for WPT, but this is still broken.

gsnedders added a commit to gsnedders/web-platform-tests that referenced this pull request Mar 22, 2019
Revert "Add actionsWithKeyPressed.html FAIL expectations for Chrome"
This reverts commit 09f993e.

Reverting web-platform-tests#15512. This makes infrastructure/ fail on TaskCluster.
gsnedders added a commit to gsnedders/web-platform-tests that referenced this pull request Mar 22, 2019
Revert "Fix actionsWithKeyPressed.html.ini"
This reverts commit a83f274.

Reverting web-platform-tests#15512. This makes infrastructure/ fail on TaskCluster.
gsnedders added a commit to gsnedders/web-platform-tests that referenced this pull request Mar 22, 2019
Revert "[ChromeDriver] Set key modifiers with mouse actions"
This reverts commit c9e9064.

Reverting web-platform-tests#15512. This makes infrastructure/ fail on TaskCluster.
foolip added a commit that referenced this pull request Mar 22, 2019
foolip added a commit that referenced this pull request Mar 22, 2019
foolip added a commit that referenced this pull request Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.