Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put TaskCluster environment variables into the yml file #16021

Merged
merged 2 commits into from Mar 22, 2019

Conversation

@jgraham
Copy link
Contributor

jgraham commented Mar 22, 2019

This avoids escaping issues when the data contains unescaped shell
special characters, notably ' but possibly also ` " $ ! and similar.

Fixes #15994

This avoids escaping issues when the data contains unescaped shell
special characters, notably ' but possibly also ` " $ ! and similar.
@wpt-pr-bot wpt-pr-bot added the infra label Mar 22, 2019
Copy link
Member

Hexcles left a comment

LGTM (I didn't know we had this lever and was playing with heredocs, which isn't great...)

@Hexcles

This comment has been minimized.

Copy link
Member

Hexcles commented Mar 22, 2019

@jgraham looking at the logs from this PR, I think this works, but it takes some deduction to come to that conclusion (based on the fact that GITHUB_BRANCH is correct, which is extracted from TASK_EVENT). Can we make the error case more obvious by adding a warning here?

except KeyError:

@wpt-pr-bot wpt-pr-bot added the ci label Mar 22, 2019
@wpt-pr-bot wpt-pr-bot requested review from gsnedders and jugglinmike Mar 22, 2019
@jgraham jgraham merged commit a007c4b into master Mar 22, 2019
24 of 25 checks passed
24 of 25 checks passed
tools/ unittests (Python 3) Taskcluster (pull_request)
Details
Azure Pipelines Build #20190322.116 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests (Safari Technology Preview)) affected tests (Safari Technology Preview) succeeded
Details
Azure Pipelines (affected tests without changes (Safari Technology Preview)) affected tests without changes (Safari Technology Preview) succeeded
Details
Azure Pipelines (infrastructure/ tests (macOS)) infrastructure/ tests (macOS) succeeded
Details
Azure Pipelines (tools/ unittests (macOS)) tools/ unittests (macOS) succeeded
Details
Azure Pipelines (tools/wpt/ tests (macOS)) tools/wpt/ tests (macOS) succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Travis CI - Pull Request Build Passed
Details
infrastructure/ tests Taskcluster (pull_request)
Details
lint Taskcluster (pull_request)
Details
resources/ tests Taskcluster (pull_request)
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
tools/ unittests (Python 2) Taskcluster (pull_request)
Details
tools/wpt/ tests Taskcluster (pull_request)
Details
update built tests Taskcluster (pull_request)
Details
wpt-chrome-dev-results Taskcluster (pull_request)
Details
wpt-chrome-dev-results-without-changes Taskcluster (pull_request)
Details
wpt-chrome-dev-stability Taskcluster (pull_request)
Details
wpt-firefox-nightly-results Taskcluster (pull_request)
Details
wpt-firefox-nightly-results-without-changes Taskcluster (pull_request)
Details
wpt-firefox-nightly-stability Taskcluster (pull_request)
Details
wpt.fyi - safari[experimental] Safari results
Details
@gsnedders gsnedders deleted the tc_env branch Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.