Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "[ChromeDriver] Set key modifiers with mouse actions" #16023

Closed
wants to merge 2 commits into from

Conversation

@foolip
Copy link
Member

foolip commented Mar 22, 2019

Landed in #15512.

Reverted in #16022.

@foolip
Copy link
Member Author

foolip commented Mar 22, 2019

@SummerLW sorry to say there was more trouble with this test. If infrastructure/ tests fail on this PR, can you check the reason and suggest the right fix?

@foolip foolip assigned LanWei22 and unassigned jugglinmike Mar 22, 2019
@gsnedders
Copy link
Contributor

gsnedders commented Mar 22, 2019

(Note that infrastructure currently isn't a blocking job, because otherwise we couldn't land anything from before when TC moved to using GH Checks.)

@foolip
Copy link
Member Author

foolip commented Mar 22, 2019

Aha. The export bot merged #15512 without the tests even having run. Taskcluster did fail but the infrastructure tests hadn't been moved then.

@foolip
Copy link
Member Author

foolip commented Mar 22, 2019

@gsnedders looks like the failure isn't due to this change, but because of generate_test_report. @LukeZielinski can you get that passing on master by adding the appropriate expectations?

@LukeZielinski
Copy link
Contributor

LukeZielinski commented Mar 22, 2019

@foolip So the generate_test_api test already has an "ERROR" expectation set for firefox. And this is working as expected I think.

I see in the log that the problem is from infrastructure/testdriver/actions/actionsWithKeyPressed.html - it's expecting an ERROR but it's getting either OK or FAIL (I actually can't tell which)?

TEST-UNEXPECTED-FAIL | /infrastructure/testdriver/actions/actionsWithKeyPressed.html | TestDriver actions: actions with key pressed - assert_array_equals: lengths differ, expected 3 got 1 @http://web-platform.test:8000/infrastructure/testdriver/actions/actionsWithKeyPressed.html:64:34 Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1587:25 Test.prototype.step_func_done/<@http://web-platform.test:8000/resources/testharness.js:1627:32 promise callback*@http://web-platform.test:8000/infrastructure/testdriver/actions/actionsWithKeyPressed.html:64:6 Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1587:25 async_test@http://web-platform.test:8000/resources/testharness.js:576:22 @http://web-platform.test:8000/infrastructure/testdriver/actions/actionsWithKeyPressed.html:39:1 TEST-UNEXPECTED-OK | /infrastructure/testdriver/actions/actionsWithKeyPressed.html | expected ERROR TEST-INFO expected ERROR | took 607ms

@gsnedders
Copy link
Contributor

gsnedders commented Mar 22, 2019

@foolip @LukeZielinski is right, that's getting an expected ERROR.

@LukeZielinski the harness is getting OK and not ERROR; the subtest is getting FAIL and not OK, hence the two unexpected results.

@foolip
Copy link
Member Author

foolip commented Apr 1, 2019

@gsnedders I tried updating expectations manually based on what you said, let's see how that goes.

@foolip foolip force-pushed the foolip/reland-15512 branch from 490d758 to 04096d9 Apr 2, 2019
@foolip
Copy link
Member Author

foolip commented Aug 16, 2019

Already relanded in #17678.

@foolip foolip closed this Aug 16, 2019
@foolip foolip deleted the foolip/reland-15512 branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.