Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to bitmaprenderer in OffscreenCanvas #16032

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

commented Mar 22, 2019

Registering the factory on OffscreenCanvas in modules, adding
ImageBitmapRenderer to the union type for OffscreenCanvas.
Adding new functionality to bitmaprenderer to let it be used
in offscreencanvas.
Changing IDL and some tests to validate new functionality.
Adding a new virtual test to guarantee testing validation
of trasnsfertooffscreencanvas for bitmaprenderer.

Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ufFQ4OvtqxQ

Bug: 907141
Change-Id: Ibcac820288bab336a1cf01b528eb3f41ece9c832
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1483831
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663341}


Closed by @rakuco because the Chromium CL was reverted before this pull request landed.

Revert "Adding support to bitmaprenderer in OffscreenCanvas"

This reverts commit 4d6ff3a874d10c167eee24de19ca0e51974eb1da.

Reason for revert: fast/canvas/gpu-threaded-compositing/OffscreenCanvas-Bitmaprenderer-TransferControl-worker.html in webkit_layout_tests has been failing since https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/80651

Original change's description:
> Adding support to bitmaprenderer in OffscreenCanvas
> 
> Registering the factory on OffscreenCanvas in modules, adding
> ImageBitmapRenderer to the union type for OffscreenCanvas.
> Adding new functionality to bitmaprenderer to let it be used
> in offscreencanvas.
> Changing IDL and some tests to validate new functionality.
> Adding a new virtual test to guarantee testing validation
> of trasnsfertooffscreencanvas for bitmaprenderer.
> 
> 
> Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ufFQ4OvtqxQ
> 
> Bug: 907141
> Change-Id: Ibcac820288bab336a1cf01b528eb3f41ece9c832
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1483831
> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Fernando Serboncini <fserb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#663341}

TBR=chrishtr@chromium.org,fserb@chromium.org,juanmihd@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 907141
Change-Id: Ib0c9fe51ddf1cd0c527b78e2a245ec03341991c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630383
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663496}

(Including this information in PR description to cause both wpt-exporter to stop trying to export the both commits and wpt-importer to try to apply it on top of a vanilla WPT checkout.)

@wpt-pr-bot
Copy link
Collaborator

left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1483831 branch 20 times, most recently from 453edb2 to 2542209 Mar 22, 2019

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1483831 branch 2 times, most recently from 97764d4 to 4e70fb6 Mar 29, 2019

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1483831 branch 2 times, most recently from a3e88d6 to b8d05a1 Apr 1, 2019

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1483831 branch from b8d05a1 to 49a8960 Apr 2, 2019

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1483831 branch 3 times, most recently from 8ec839b to 0d8afd1 Apr 12, 2019

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1483831 branch from 0d8afd1 to 3e7aa66 Apr 30, 2019

annevk added a commit to whatwg/html that referenced this pull request May 14, 2019

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1483831 branch 2 times, most recently from 593fb32 to a271d06 May 17, 2019

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1483831 branch from a271d06 to 1759c8b May 24, 2019

Adding support to bitmaprenderer in OffscreenCanvas
Registering the factory on OffscreenCanvas in modules, adding
ImageBitmapRenderer to the union type for OffscreenCanvas.
Adding new functionality to bitmaprenderer to let it be used
in offscreencanvas.
Changing IDL and some tests to validate new functionality.
Adding a new virtual test to guarantee testing validation
of trasnsfertooffscreencanvas for bitmaprenderer.

Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ufFQ4OvtqxQ

Bug: 907141
Change-Id: Ibcac820288bab336a1cf01b528eb3f41ece9c832
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1483831
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663341}
@rakuco

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

Closing, this was reverted in Chromium before this PR landed (see PR description for more information).

@rakuco rakuco closed this May 27, 2019

@rakuco rakuco deleted the chromium-export-cl-1483831 branch May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.