Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpt: Support http://host:80/ at EventListener / incumbent test #16800

Merged
merged 1 commit into from May 15, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented May 13, 2019

MessageEvent's origin attribute will be
http://hostname
instead of
http://hostname:80
in case that the port number is HTTP standard port number, i.e. 80.

Usually this is not a problem because wptserve runs with port=8001
by default, but w3c-test.org runs with port=80.
http://w3c-test.org/dom/events/EventListener-incumbent-global-2.sub.html

This patch supports such a case.

Bug: 622974
Change-Id: I4567de3f5f12ae42c222229eafafecbbe72129e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610097
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659871}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1610097 branch from 2ee6109 to 62a6c4b May 14, 2019
MessageEvent's origin attribute will be
    http://hostname
instead of
    http://hostname:80
in case that the port number is HTTP standard port number, i.e. 80.

Usually this is not a problem because wptserve runs with port=8001
by default, but w3c-test.org runs with port=80.
http://w3c-test.org/dom/events/EventListener-incumbent-global-2.sub.html

This patch supports such a case.

Bug: 622974
Change-Id: I4567de3f5f12ae42c222229eafafecbbe72129e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610097
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659871}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1610097 branch from 62a6c4b to 0a81584 May 15, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 131d17e into master May 15, 2019
13 checks passed
13 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
website-build-and-publish website-build-and-publish
Details
Azure Pipelines Build #20190515.38 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests (Safari Technology Preview)) affected tests (Safari Technology Preview) succeeded
Details
Azure Pipelines (affected tests without changes (Safari Technology Preview)) affected tests without changes (Safari Technology Preview) succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1610097 branch May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.