Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html: Add a testcase for submit event reentrancy protection #16811

Merged
merged 3 commits into from May 15, 2019

Conversation

@tkent-google
Copy link
Contributor

tkent-google commented May 14, 2019

Specification: whatwg/html#4621

Copy link
Member

domenic left a comment

LGTM with minor question/nit

let test10 = async_test('Cannot navigate (after constructing the entry list)');
test10.step(() => {

async_test(t => {

This comment has been minimized.

Copy link
@domenic

domenic May 14, 2019

Member

Do you think this style of test is better than the counter style used above? If so, maybe add a comment?

This comment has been minimized.

Copy link
@tkent-google

tkent-google May 15, 2019

Author Contributor

I'd like to test which one of two click()s submits the form. I'll add a comment.

domenic added a commit to whatwg/html that referenced this pull request May 15, 2019
Fixes #4620. This flag prevents reentrancy into the submission algorithm
during submit or invalid events. Blink and Gecko implement this for
submit only; WebKit implements it for both. The specification chooses
WebKit's behavior.

Tests: web-platform-tests/wpt#16811
Copy link
Member

domenic left a comment

New test LGTM with nit, although still unclear why one test uses navigation and the others use counters.

@tkent-google tkent-google merged commit 7ffd31b into master May 15, 2019
11 checks passed
11 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
Azure Pipelines Build #20190515.171 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests (Safari Technology Preview)) affected tests (Safari Technology Preview) succeeded
Details
Azure Pipelines (affected tests without changes (Safari Technology Preview)) affected tests without changes (Safari Technology Preview) succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
wpt.fyi - safari[experimental] Safari results
Details
@tkent-google tkent-google deleted the tkent-submit-event-protection branch May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.