Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Sec-Fetch-... headers from service worker `fetch` event. #16833

Merged
merged 1 commit into from May 15, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented May 14, 2019

This CL excludes Sec-Fetch-... request headers from the Request object
passes to the service worker's fetch event. This CL also adds WPT
tests that verify that these request headers will be re-added when the
service worker forwards the request back into the network (via implicit
fallback, or via an explicit responseWith+fetch).

Bug: 949997
Change-Id: I04422a1630f62b497961ca1789007f2402148e76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611314
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659937}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1611314 branch from 90c5053 to 68a25be May 15, 2019
This CL excludes Sec-Fetch-... request headers from the Request object
passes to the service worker's `fetch` event.  This CL also adds WPT
tests that verify that these request headers will be re-added when the
service worker forwards the request back into the network (via implicit
fallback, or via an explicit responseWith+fetch).

Bug: 949997
Change-Id: I04422a1630f62b497961ca1789007f2402148e76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611314
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659937}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1611314 branch from 68a25be to 188318a May 15, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 318a0a3 into master May 15, 2019
15 checks passed
15 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
website-build-and-publish website-build-and-publish
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190515.100 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests (Safari Technology Preview)) affected tests (Safari Technology Preview) succeeded
Details
Azure Pipelines (affected tests without changes (Safari Technology Preview)) affected tests without changes (Safari Technology Preview) succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1611314 branch May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.