Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IntersectionObserver] Fix target rect for block inside inline #16834

Merged
merged 1 commit into from May 15, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented May 14, 2019

As the spec requires, use the same logic as
Element::getBoundingClientRect for the target rect.

BUG=962605
R=eae@chromium.org

Change-Id: Ib5aaec30d9de79901d08f8fe3ce0a3998468839f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612032
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659836}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

As the spec requires, use the same logic as
Element::getBoundingClientRect for the target rect.

BUG=962605
R=eae@chromium.org

Change-Id: Ib5aaec30d9de79901d08f8fe3ce0a3998468839f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612032
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659836}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1612032 branch from 0043a37 to 0c936a9 May 15, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit cf40205 into master May 15, 2019
13 checks passed
13 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
website-build-and-publish website-build-and-publish
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190515.20 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests (Safari Technology Preview)) affected tests (Safari Technology Preview) succeeded
Details
Azure Pipelines (affected tests without changes (Safari Technology Preview)) affected tests without changes (Safari Technology Preview) succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
wpt.fyi - firefox[experimental] Firefox results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1612032 branch May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.