Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CSS color-scheme property. #16839

Merged
merged 1 commit into from May 22, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented May 15, 2019

Implemented behind a flag.

The implementation currently doesn't apply the computed color-scheme to
any rendering.

Spec:

https://drafts.csswg.org/css-color-adjust-1/#color-scheme-prop

Intent to implement:

https://groups.google.com/a/chromium.org/d/topic/blink-dev/xXVJlqlDL_k/discussion

Bug: 939811
Change-Id: Ieec8eb247155c02f0df56a9c637a8e1486c0b404
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601255
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662146}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1601255 branch 2 times, most recently from 3ba66ac to 07d22e1 May 20, 2019
Implemented behind a flag.

The implementation currently doesn't apply the computed color-scheme to
any rendering.

Spec:

https://drafts.csswg.org/css-color-adjust-1/#color-scheme-prop

Intent to implement:

https://groups.google.com/a/chromium.org/d/topic/blink-dev/xXVJlqlDL_k/discussion

Bug: 939811
Change-Id: Ieec8eb247155c02f0df56a9c637a8e1486c0b404
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601255
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662146}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1601255 branch from 07d22e1 to 743ac6f May 22, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit f391659 into master May 22, 2019
12 checks passed
12 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
website-build-and-publish website-build-and-publish
Details
wpt.fyi - chrome[experimental] Chrome results
Details
Azure Pipelines Build #20190522.33 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests (Safari Technology Preview)) affected tests (Safari Technology Preview) succeeded
Details
Azure Pipelines (affected tests without changes (Safari Technology Preview)) affected tests without changes (Safari Technology Preview) succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1601255 branch May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.