Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-text] break-all opportunities to avoid breaking before first space #16843

Merged
merged 1 commit into from May 15, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented May 15, 2019

The 'white-space: break-spaces' feature, when used in combination with
'overfow-wrap: break-word' may allow breaking before the first space
after a word.

However, we should avoid it if there are previous opportunities, like
white spaces.

The 'word-break: break-all' feature allows breaking a word at any
letter. Since the goal of this feature is produce the longest line as
possible, these additional opportunities must be prioritized over any
previous white space.

Bug: 952254
Change-Id: I0b1c31219c0009c7050084dd552317342ec25b8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613177
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#660072}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

The 'white-space: break-spaces' feature, when used in combination with
'overfow-wrap: break-word' may allow breaking before the first space
after a word.

However, we should avoid it if there are previous opportunities, like
white spaces.

The 'word-break: break-all' feature allows breaking a word at any
letter. Since the goal of this feature is produce the longest line as
possible, these additional opportunities must be prioritized over any
previous white space.

Bug: 952254
Change-Id: I0b1c31219c0009c7050084dd552317342ec25b8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613177
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#660072}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1613177 branch from 5b649d4 to a5cd305 May 15, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 5f2afb0 into master May 15, 2019
15 checks passed
15 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
website-build-and-publish website-build-and-publish
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190515.149 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests (Safari Technology Preview)) affected tests (Safari Technology Preview) succeeded
Details
Azure Pipelines (affected tests without changes (Safari Technology Preview)) affected tests without changes (Safari Technology Preview) succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1613177 branch May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.