Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wpt] Don't make unimplemented CSS properties PASS. #16845

Merged
merged 1 commit into from May 15, 2019

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented May 15, 2019

For computed style and inheritance tests, we silently passed
unimplemented CSS properties. Assert that they exist, and if not, fail
instead.

R=ericwilligers@chromium.org

Change-Id: I1f62bb2ef93b84528373b329dadefb6162ce19c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609850
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660172}

Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1609850 branch from 5e5cabe to cdfafbc May 15, 2019
For computed style and inheritance tests, we silently passed
unimplemented CSS properties. Assert that they exist, and if not, fail
instead.

R=ericwilligers@chromium.org

Change-Id: I1f62bb2ef93b84528373b329dadefb6162ce19c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609850
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660172}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1609850 branch from cdfafbc to bd6e8d1 May 15, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit e8b0b32 into master May 15, 2019
15 checks passed
15 checks passed
manifest-build-and-tag manifest-build-and-tag
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
website-build-and-publish website-build-and-publish
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190515.167 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests (Safari Technology Preview)) affected tests (Safari Technology Preview) succeeded
Details
Azure Pipelines (affected tests without changes (Safari Technology Preview)) affected tests without changes (Safari Technology Preview) succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1609850 branch May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.